Kratos icon indicating copy to clipboard operation
Kratos copied to clipboard

Fix various typos in doxygen and misc. source comments

Open luzpaz opened this issue 3 years ago • 9 comments
trafficstars


name: 🗎 Documentation and Styling about: Adding or modifying documentation or code style.


Description

Fixing typos in doxygen and cleaning up varioys typos in source comments

Changelog

-Fixed doxygen and source comment typos

luzpaz avatar Aug 07 '22 20:08 luzpaz

Just comments, so a priori the code is not affected. Thanks

As this is your first contribution, it also requires the approval of a maintainer. Therefore, @KratosMultiphysics/technical-committee. @roigcarlo can you take a look?

loumalouomega avatar Aug 08 '22 06:08 loumalouomega

soft bump

luzpaz avatar Aug 15 '22 11:08 luzpaz

There is a conflict that must be solved

loumalouomega avatar Aug 15 '22 20:08 loumalouomega

Conflict solved. Rebased

luzpaz avatar Aug 15 '22 20:08 luzpaz

Rebased on master.

Please move to kratos/python_scripts/testing/run_tests.py

@loumalouomega that file doesn't exist on this branch.

Screenshot_20220815_201120

luzpaz avatar Aug 16 '22 00:08 luzpaz

Rebased on master.

Please move to kratos/python_scripts/testing/run_tests.py

@loumalouomega that file doesn't exist on this branch.

Screenshot_20220815_201120

Because you solve the conflict in a wrong manner. Please, add manually the file, with the corresponding corrections and I will allow the merge

loumalouomega avatar Aug 16 '22 06:08 loumalouomega

Because you solve the conflict in a wrong manner. Please, add manually the file, with the corresponding corrections and I will allow the merge

:facepalm: so sorry! Have no idea how that happened. That's actually never happened to me before until now. Reverted in 28e403d

luzpaz avatar Aug 16 '22 11:08 luzpaz

shall i rebase?

luzpaz avatar Aug 31 '22 19:08 luzpaz

shall i rebase?

Wait until CI passes and just merge

loumalouomega avatar Sep 01 '22 06:09 loumalouomega

Let me know if rebase is needed

luzpaz avatar Nov 28 '22 17:11 luzpaz

Can someone re-aprove?

roigcarlo avatar Feb 28 '23 13:02 roigcarlo

I will try to merge these as they were already approved from long ago

roigcarlo avatar Feb 28 '23 15:02 roigcarlo