Kratos icon indicating copy to clipboard operation
Kratos copied to clipboard

CoSim important FSI tests are disabled

Open philbucher opened this issue 3 years ago • 4 comments

@KratosMultiphysics/cosimulation the Mok-FSI tests are currently disabled (see here and here) https://github.com/KratosMultiphysics/Kratos/blob/b9769b6578ba5cd9472e4834ad6cf4c193bc9501/applications/CoSimulationApplication/tests/test_CoSimulationApplication.py#L81-L83

@roigcarlo according to the history you made these changes? Those tests are probably the most important tests in the app, why did you disable them?

philbucher avatar Jul 10 '22 13:07 philbucher

Those were disabled when we set nightly as the default suit because they were faulty (they were failing 50% of times they were executed) , they can be re-enable as long as they are fixed.

Edit: see #9796

roigcarlo avatar Jul 10 '22 13:07 roigcarlo

Ah I thought that was not merged because of failing tests 😅

In any case, out of all tests in Kratos those two were the ones I trusted most If they are failing then I am a bit scared, as they test the entire workflow

@KratosMultiphysics/cosimulation would someone habe time to run them to see if they fail?

philbucher avatar Jul 10 '22 16:07 philbucher

@roigcarlo it is pretty concerning it these were turned off @philbucher I will try to take a look asap @mtnzguillermo this might effect you as well

mpentek avatar Jul 19 '22 07:07 mpentek

Hopefully fixed with #10108.

mpentek avatar Aug 05 '22 14:08 mpentek