Stefan Krastanov

Results 268 comments of Stefan Krastanov

Is this able to generate all RS codes or is there some limitation on the size? It seems 255 is hardcodded as the largest number of physical bits possible. If...

It is impressive that the BCHs are also added now! Just a quick advice on structuring PRs like this to make it easier to review. Here for instances, BCH is...

I will probably try to review the previous PR first, which wont happen until maybe the weekend.

> BCH case This generates the generator polynomial, and then is method to get to parity check matrix. Kindly please see the https://web.ntpu.edu.tw/~yshan/BCH_code.pdf (Pages 14 to 16). Please let me...

Page 14 talks about some alphas that define the code. Do you have them? Page 17 talks about taking powers of alpha and then expressing them as binary column vectors....

> > Page 17 talks about taking powers of alpha and then expressing them as binary column vectors. Can you do that? > > My guess is that we can...

> Sounds interesting, but doesn't this assumes that we have constructed H as a matrix not as a polynomial, right? Not really. You can put whatever you wish in a...

I think it is just a minor bug in how you define the sMZ measurement. It needs two arguments, not just one. Implicitly, if you have only one argument it...

We should have a warning when the circuit contain measurement that discard the result (i.e. when we have `sMZ(qubit)` instead of `sMZ(qubit,bit)`).

Good point! We should probably define a few methods that raise errors. Something along the lines of ``` apply!(s, ::Type{