kotlinx.coroutines icon indicating copy to clipboard operation
kotlinx.coroutines copied to clipboard

Published 20 hours ago • verified publisher icon Kotlin

Display artificial stack frames as calls to functions instead of text

Open dkhalanskyjb opened this issue 3 years ago • 3 comments

Originally implemented in #2461. I just cherry-picked it and made sure the project builds.

Fixes https://github.com/Kotlin/kotlinx.coroutines/issues/2291

dkhalanskyjb avatar Dec 08 '21 11:12 dkhalanskyjb

This change is supported since 212. The support for 211 stopped with 2021.1.3 coming out, which was this summer: https://blog.jetbrains.com/idea/2021/06/intellij-idea-2021-1-3/

dkhalanskyjb avatar Dec 09 '21 09:12 dkhalanskyjb

Could you please figure out whether we are allowed to merge this change?

qwwdfsad avatar Sep 08 '22 14:09 qwwdfsad

The last Kotlin Plugin version to support IDEA 211 was 1.6.21. So, I think we're good to go.

dkhalanskyjb avatar Sep 09 '22 09:09 dkhalanskyjb

  1. Both navigation to the stub symbols and the debugger work as intended with the latest versions of everything and this change.
  2. I don't think such an issue was ever filed.

dkhalanskyjb avatar Oct 13 '22 13:10 dkhalanskyjb

I don't think such an issue was ever filed.

That's a bummer, could you please ask Nikita to do so and to link the commit with the change in IDEA to it?

qwwdfsad avatar Oct 14 '22 09:10 qwwdfsad

Seems like my previous message got lost (?), though the labels edit didn't. Anyway, all the required commits are in place in all our supported platforms: 657936acb69fbbc59a88e1b7e799f49e81d9f162 (for Ultimate repo) and https://github.com/JetBrains/intellij-community/commit/fd29488cce387808d564d1e3c2ed830c7724c22f

Changes are good to go

qwwdfsad avatar Oct 20 '22 14:10 qwwdfsad

Here's the older comment: https://github.com/Kotlin/kotlinx.coroutines/issues/2291#issuecomment-1279142363 No harm in repeating this, I think.

dkhalanskyjb avatar Oct 20 '22 14:10 dkhalanskyjb