kotlinx-kover icon indicating copy to clipboard operation
kotlinx-kover copied to clipboard

Multiline assertFailsWith marks as uncovered

Open soywiz opened this issue 3 years ago • 5 comments
trafficstars

In 0.6.1 with ./gradlew koverMergedXmlReport uploaded to codecov:

https://app.codecov.io/github/korlibs/korge/blob/31ceb8d90c8adf02931e410d385f704e513d56b4/kds/src/commonTest/kotlin/com/soywiz/kds/QueueTest.kt

Screenshot 2022-10-04 at 18 24 25

Also I'm getting some strange partial here in the same file:

Screenshot 2022-10-04 at 18 24 58

soywiz avatar Oct 04 '22 16:10 soywiz

Hi, at the moment, correct integration with codecov is not guaranteed.

Could you please show the Kover HTML report? How different is it from codecov.

shanshin avatar Oct 04 '22 17:10 shanshin

@shanshin

Screenshot 2022-10-04 at 19 39 28

You should be able to reproduce this report with:

git clone https://github.com/korlibs/korge.git
git checkout 3b7f877eb1fb3be09e9669453a86eb75c1b3df23
./gradlew :kds:koverHtmlReport

soywiz avatar Oct 04 '22 17:10 soywiz

List.isNotEmpty partial coverage is fixed in agent version 1.0.688

As for assertFailesWith, this issue is caused by insufficient support of @InlineOnly functions in the coverage agent

zuevmaxim avatar Nov 22 '22 10:11 zuevmaxim

Nice! Confirmed that List.isNotEmpty thing is fixed:

Screenshot 2022-11-22 at 12 00 48

soywiz avatar Nov 22 '22 11:11 soywiz

Related issue about InlineOnly functions https://youtrack.jetbrains.com/issue/KT-55381

zuevmaxim avatar Dec 13 '22 09:12 zuevmaxim

Fixed since 0.8.0

shanshin avatar Jun 24 '24 15:06 shanshin