kotlinx-datetime icon indicating copy to clipboard operation
kotlinx-datetime copied to clipboard

Published 20 hours ago • verified publisher icon Kotlin

Wasm/WASI target implementation

Open igoriakovlev opened this issue 11 months ago • 3 comments

This is Wasm/WASI target implementation. It based on native version with hardcoded tzdb.

  1. Extracted native implementation into intermediate sourceset.
  2. Added WASI implementation
  3. Added timezones-full database project

Before building timezones project you should run generateWasmWasiZoneInfo task to download and convert timezones db (nodejs and npm should be installed in the system). We decided to put the result of this task into the repository but for review it is not generated yet.

igoriakovlev avatar Mar 11 '24 19:03 igoriakovlev

The build fails because of none of TZ binaries in the PR.

igoriakovlev avatar Mar 12 '24 14:03 igoriakovlev

I have rebased onto the master and merged all the AMEND commits by @dkhalanskyjb request.

igoriakovlev avatar May 21 '24 14:05 igoriakovlev

I sqashed commits so PR is ready to merge. All tests passed. Thank you a lot for the review!

igoriakovlev avatar Aug 09 '24 12:08 igoriakovlev

If this is good to go, could you rebase it on top of master so that we can merge it?

dkhalanskyjb avatar Sep 02 '24 13:09 dkhalanskyjb

If this is good to go, could you rebase it on top of master so that we can merge it?

It is done.

igoriakovlev avatar Sep 02 '24 16:09 igoriakovlev

Great job, thanks!

dkhalanskyjb avatar Sep 05 '24 14:09 dkhalanskyjb