kotlinx-cli
kotlinx-cli copied to clipboard
Make output functions open rather than final
Will help with #53 and is overall a Good Thing (TM)
Changes in tests with such approach make them a bit less demonstrative. Let's ask @ilya-g opinion
Changes in tests with such approach make them a bit less demonstrative. Let's ask @ilya-g opinion
I thought it would make the tests better, since they are only testing public API now rather than using internal details. The tested surface remains the same overall since the old tests didn't test the exitProcess code either. But I'm no expert in testing nor kotlinx.cli so don't listen to me!
We definitely want to address #53 somehow, but using inheritance for that is not something that we're considering.
We definitely want to address #53 somehow, but using inheritance for that is not something that we're considering.
Could I ask why? It feels like the most idiomatic way to me, so if it isn't, could you please help me understand why so I don't make the mistake again? Thanks!
@ilya-g ping. Would it be more appropriate to simply make outputAndTerminate public?
@ilya-g ping. I would very much like this to be fixed :)