kotlinx-cli icon indicating copy to clipboard operation
kotlinx-cli copied to clipboard

Make output functions open rather than final

Open penn5 opened this issue 3 years ago • 6 comments

Will help with #53 and is overall a Good Thing (TM)

penn5 avatar May 09 '21 21:05 penn5

Changes in tests with such approach make them a bit less demonstrative. Let's ask @ilya-g opinion

LepilkinaElena avatar May 13 '21 14:05 LepilkinaElena

Changes in tests with such approach make them a bit less demonstrative. Let's ask @ilya-g opinion

I thought it would make the tests better, since they are only testing public API now rather than using internal details. The tested surface remains the same overall since the old tests didn't test the exitProcess code either. But I'm no expert in testing nor kotlinx.cli so don't listen to me!

penn5 avatar May 13 '21 20:05 penn5

We definitely want to address #53 somehow, but using inheritance for that is not something that we're considering.

ilya-g avatar May 14 '21 18:05 ilya-g

We definitely want to address #53 somehow, but using inheritance for that is not something that we're considering.

Could I ask why? It feels like the most idiomatic way to me, so if it isn't, could you please help me understand why so I don't make the mistake again? Thanks!

penn5 avatar May 14 '21 18:05 penn5

@ilya-g ping. Would it be more appropriate to simply make outputAndTerminate public?

penn5 avatar May 17 '21 19:05 penn5

@ilya-g ping. I would very much like this to be fixed :)

BenjaminHolland avatar Jul 15 '21 03:07 BenjaminHolland