kotlinx-benchmark icon indicating copy to clipboard operation
kotlinx-benchmark copied to clipboard

Update publish-plugin to published signed plugin artifacts

Open fzhinkin opened this issue 9 months ago • 7 comments

Updated infra and published plugins to unlock signed plugin artifacts publication.

Closes #115

fzhinkin avatar Mar 05 '25 20:03 fzhinkin

I tried to test it by changing plugin id and publishing it from my personal account. Obviously, verification on the portal side failed and the submission was rejected, but looking into Gradle's logs it seems like .asc files for plugin were uploaded.

@adam-enko, @Tapchicoma maybe you guys know a better testing approach?

fzhinkin avatar Mar 05 '25 20:03 fzhinkin

@adam-enko, @Tapchicoma maybe you guys know a better testing approach?

Personally I test publishing by adding a local directory and manually verifying the files.

Example: https://github.com/kotest/kotest/blob/26db26e6275cad3c67e4562aa779c9f00dc01eeb/buildSrc/src/main/kotlin/kotest-publishing-conventions.gradle.kts#L61-L65

adam-enko avatar Mar 06 '25 08:03 adam-enko

Looking at the PR, imho it'd be better to update kotlinx team infra plugin to avoid such workarounds. The last time I looked at the infra plugin it used a lot of non-idiomatic practices that could be refactored to avoid these issues. Is updating the infra plugin feasible?

adam-enko avatar Mar 06 '25 08:03 adam-enko

it'd be better to update kotlinx team infra plugin to avoid such workarounds.

I considered that option, but there's only a few projects still using the plugin and I though it would be easier to update one of them to exclude the duplicated artifact instead of updating all other projects to include it explicitly.

the infra plugin it used a lot of non-idiomatic practices that could be refactored to avoid these issues

It makes sense to do all that at some point and then get rid of the workaround I'm adding here.

fzhinkin avatar Mar 07 '25 16:03 fzhinkin

Personally I test publishing by adding a local directory and manually verifying the files.

Apparently, signature files are always published to a local repo, no matter what version of publish plugin I'm using :/

fzhinkin avatar Mar 07 '25 17:03 fzhinkin

I just saw another user posted in the Gradle Slack with the same problem. Possibly there's an issue with the Plugin Portal?

image

https://gradle-community.slack.com/archives/CA745PZHN/p1741602255845399 (archive)

adam-enko avatar Mar 10 '25 10:03 adam-enko

I'll check it, thanks for pointing to it!

fzhinkin avatar Mar 11 '25 14:03 fzhinkin