kotlindl icon indicating copy to clipboard operation
kotlindl copied to clipboard

Simplify working with optimizer variables

Open juliabeliaeva opened this issue 2 years ago • 3 comments

This PR deals with optimizer variables created by the createSlot function. Instead of creating variables in the Optimizer#createSlots, putting them to the special map only to retrieve in the applyGradients, which is called directly after, variables are created immediately before usage.

juliabeliaeva avatar Apr 13 '22 11:04 juliabeliaeva

It's an interesting proposal, but I need a time to estimate the power of this refactoring, give me a couple of days here to trace all the code routes in refactored optimizers

zaleslaw avatar Apr 22 '22 16:04 zaleslaw

@zaleslaw I don't think this refactoring should be included into the 0.4 so there is really no rush with the review.

juliabeliaeva avatar Apr 22 '22 18:04 juliabeliaeva

If you suppose to postpone it, I suggest marking it with the 0.5 milestone

zaleslaw avatar Apr 26 '22 11:04 zaleslaw