kotlindl
kotlindl copied to clipboard
Kotlin
[Draft] Github CI, DSL Builder, Seperate logging factory
Looks interesting, thanks for this PR, I need a time to check on my fork and return with the results
Hi @smallshen @zaleslaw,
I would like to see Gradle wrapper validation in use. https://github.com/gradle/wrapper-validation-action
This small action validates, thats the checked in gradle-wrapper.jar was created by Gradle. It takes nearly no time and provides security.
@smallshen I already created a PR in your fork. https://github.com/smallshen/KotlinDL/pull/1 Thanks!
@zaleslaw I saw the conflicts on onnx/build.gradle It is caused by Gradle version, newer version of Gradle use implementation
In the Kotlin compiler, lambda is compiled into an object (without compiler flags). https://github.com/MicroUtils/kotlin-logging/issues/34 And this causes performance issues
Plus the recent log4j RCE has made more people change logging frameworks, (for example, in my organization we are not allowed to use Apache related frameworks). This implementation is lightweight and easy to extend without any loss of functionality.
Hi, @smallshen you did a really great job, but this migration will be postponed for a few months to clarify the situation on the market among our users who embed the KotlinDL functionality in their apps.
- Log4j/logback and others is popular among Java/Kotlin backend developers and have widely known configuration
- Replacement of the logging framework could lead to new bugs and CVE but they will be not found so fast as in the log4j case
- In a framework like KotlinDL we will be not affected by performance issues due to a very tiny percentage time of logging methods execution in comparison to tensor calculations
But I suggest keeping this PR (probably marked as draft or something else) to revisit the problem in the next two months.
Now it contains a lot of mixed proposals (Gradle update (it's done), Github CI, DSL for building neural networks (we have a separate PR for that as I remember), and a proposal for a new logging module (which is postponed))
Log4j/logback is supported with Log4JFactory.setup(), and users don't need to change anything on their configs
But I suggest keeping this PR (probably marked as draft or something else) to revisit the problem in the next two months.
Now it contains a lot of mixed proposals (Gradle update (it's done), Github CI, DSL for building neural networks (we have a separate PR for that as I remember), and a proposal for a new logging module (which is postponed))
I agree with this
@zaleslaw
Log4j/logback and others is popular among Java/Kotlin backend developers and have widely known configuration
Creating loggers is handled internally by the log4j API, so the logging behavior stays the same using Log4JFactory and does not require any changes.
https://github.com/smallshen/KotlinDL/blob/master/logging/logging-log4j/src/main/kotlin/org/jetbrains/kotlinx/dl/logging/log4j/ Log4JFactory.kt
and everything is handled by log4j's internal logger.
https://github.com/smallshen/KotlinDL/blob/master/logging/logging-log4j/src/main/kotlin/org/jetbrains/kotlinx/dl/logging/log4j/ LoggerWrapper.kt#L30