kotlin-examples icon indicating copy to clipboard operation
kotlin-examples copied to clipboard

JS Test Examples: Move from gradle plugin com.moowork.node to de.solugo.gradle.nodejs

Open SalomonBrys opened this issue 7 years ago • 0 comments

The com.moowork.node gradle plugin is incompatible with Gradle 4.6 when GRADLE_METADATA is used. This makes it fail when used with plugins that use this feature, such as Kotlin/Native konan gradle plugin.

Therefore, when creating a multi-platform project, using the provided examples do not work.

In this PR, I propose to replace this gradle plugin with the de.solugo.gradle.nodejs plugin, which works as expected on gradle 4.6+.

This will provide examples that work in pure Kotlin/JS projects, but also in Kotlin/Everywhere projects.

Note that the karma example is untouched and is the only one that will continue to fail: the example uses the com.craigburke.karma gradle plugin, which itself depends on com.moowork.node.

This PR fixes the jasmine, jest, mocha, qunit and jest examples.

SalomonBrys avatar May 28 '18 09:05 SalomonBrys