dokka icon indicating copy to clipboard operation
dokka copied to clipboard

Published 20 hours ago • verified publisher icon Kotlin

Make dokka Gradle task cacheable

Open devisnik opened this issue 4 years ago • 8 comments

adds support for local and remote caching to DokkaTask.

addresses https://github.com/Kotlin/dokka/issues/453

devisnik avatar May 04 '20 13:05 devisnik

Hey @devisnik, thanks for your contribution 👍 Would you be able to rebase this on our latest dev-0.11.0 branch?

sellmair avatar Jul 08 '20 05:07 sellmair

Sorry for the late reply. I'll look into redoing the changes onto dev-0.11.0. Seems the test infrastructure has changed quite a bit on that branch.

devisnik avatar Aug 05 '20 08:08 devisnik

Please also check the Gradle maintenance branch! It might make sense to wait for that and adjust accordingly if there are still issues!

sellmair avatar Aug 05 '20 15:08 sellmair

@sellmair Do you mean gradle-plugin-maintenance ? I have a working version based on dev-0.11.0 now. Do you want me to PR that? Or should the change be based on gradle-plugin-maintenance ?

devisnik avatar Aug 05 '20 19:08 devisnik

Yes, I mean that branch. But I think this should be the plan: We might want to merge #1194 first and then adapt your changes on top of it ☺️

sellmair avatar Aug 10 '20 13:08 sellmair

@sellmair Sounds good to me. 😄 I've created #1296 for the changes on dev-0.11.0. We might want to adapt that one after #1194 has been merged.

Should we close this one?

devisnik avatar Aug 11 '20 07:08 devisnik

Thanks for the effort. We are actually now branching from/targeting master instead of dev-0.11.0, but those branches are not drastically different at the moment.

But there is no need of closing this right now. I will take care of it once the Gradle Plugin changes are merged ☺️

sellmair avatar Aug 11 '20 12:08 sellmair

Superseded by #1905?

keturn avatar Aug 05 '21 02:08 keturn

Can't this be closed?

eskatos avatar Jan 14 '23 08:01 eskatos

It does indeed look like it was re-implemented in https://github.com/Kotlin/dokka/pull/1905, so I'll be closing the PR. Thank you for your effort though!

Can't this be closed?

I'm reluctant to close old PRs on the basis that they are old, it's rude and we might miss out on useful changes, but it takes time to verify and revive them, and we haven't had time lately. It's on our list though.

If you see similarly stale PRs/issues that have been implemented, please point it out, I'd be happy to have a closer look

IgnatBeresnev avatar Jan 19 '23 17:01 IgnatBeresnev