dokka icon indicating copy to clipboard operation
dokka copied to clipboard
verified publisher icon Kotlin

Build script tweaks

Open 3flex opened this issue 1 year ago • 1 comments

Pretty low value stuff, but it tidies things up a little here and there.

Easiest to review commit by commit.

3flex avatar Feb 03 '24 10:02 3flex

Hi @3flex, thanks for the contribution.

I've had a quick scan through and I've applied some of these changes in my own PRs. It makes sense to split them into a separate PR, so thanks for creating this.

Updating the scripts to use the new Kotlin Assignment feature is a more notable change however. Dokka needs to support a wide range of Gradle versions, and using Kotlin Assignment requires Gradle 8.2+. We can use Kotlin Assignment in our own build scripts, but not in the tested projects, and probably not in the docs (but I'll check further).

adam-enko avatar Feb 05 '24 18:02 adam-enko

Hey @3flex ! Do you still willing to work on this PR? If so, could you please:

  • rebase on latest master (some changes could be applied already there by @adam-enko)
  • revert changes of .set to = in integration tests projects - tests for those projects are executed with different Gradle versions where property assignment via = doesn't exist
  • revert changes in dokkatoo - as stated above - this project is not connected for now

whyoleg avatar Apr 08 '24 11:04 whyoleg