dataframe
dataframe copied to clipboard
Kotlin
Document API
There is currently no documentation on interfaces like DataColumn. It makes it hard to add custom implementations for them. For example, it is not clear what ndistinct means.
0.8-rc still has a lot of problems with documentation. For example it is not clear how generic is used here: https://github.com/Kotlin/dataframe/blob/db20e697fa40af068a4cf7155e7086349f12d14a/src/main/kotlin/org/jetbrains/kotlinx/dataframe/DataFrame.kt#L22
@altavir I've added KDocs for major interfaces, please, check if it's clearer now.
A little bit. But not fully. For example, it is not clear what variance of T is allowed in the schema. Should it be variant T or all descendants of T (for example if T is Number).
The same goes for methods. Some methods are self-explanatory, but some are not. Several examples (just in this class, not going anywhere else):
-
https://github.com/Kotlin/dataframe/blob/50dadec68dec40143508fa46e5f2f4efcffdb2e1/src/main/kotlin/org/jetbrains/kotlinx/dataframe/DataFrame.kt#L47 What does it do?
-
https://github.com/Kotlin/dataframe/blob/50dadec68dec40143508fa46e5f2f4efcffdb2e1/src/main/kotlin/org/jetbrains/kotlinx/dataframe/DataFrame.kt#L43 what is the iteration order?
Thank you for quick reply. I'm currently writing KDocs and comments for the library. Probably I'll not be able cover the whole codebase, so your requests for clarification of particular parts of code are appreciated.