awscfncli icon indicating copy to clipboard operation
awscfncli copied to clipboard

Refactor for new cross-stack reference

Open Kotaimen opened this issue 6 years ago • 3 comments

  • [x] Process of convert config to boto3 call
  • [x] Abstract stack Command objects
  • [x] Separate boto3 call from click call

Kotaimen avatar Sep 22 '18 06:09 Kotaimen

Hi @GlieseRay,

Does that make sense to you to change output reference syntax from:

${Stage.Stack.OutputName}

To:

${Stage.Stack.Outputs.OutputName}

So we can add other stack references other than outputs in the future? This syntax is also identical with what nested stack uses:

Stack.Outputs.OutputName

Kotaimen avatar Oct 24 '18 09:10 Kotaimen

Hi @GlieseRay:

  1. I'd still like to support following use case:

    ${Stage.Stack.Config.ConfigName}
    ${Stage.Stack.Parameters.ParameterName}
    ${Stage.Stack.Outputs.OutputName}
    

    This leaves us room for future expansion. of course with 2.1 released we need to keep support for old format:

    ${Stage.Stack.OutputName}
    
  2. I think current "string template replacement" way of implement stack reference is not ideal and I would like to see it refactored.

  3. When retrieving outputs from a referenced stack data is not cached, I'm wondering that could be improved?

Kotaimen avatar Jan 19 '19 08:01 Kotaimen

@Kotaimen I am going to use mustache or something else. Testing.

GlieseRay avatar Mar 08 '19 14:03 GlieseRay