minecraftPlayerAnimator
minecraftPlayerAnimator copied to clipboard
KosmX
Added support for easing arguments
Pretty self explanatory, some easings now use the easingArgs parts of a Blockbench animation json I have tested this personally and it works great I didn't touch your networking though so animations synced through that won't support this feature I also tried my best to make sure this doesn't break anything with mods developed on older versions
You also forgot to change the hashCode and toString methods of the KeyFrame class
You also forgot to change the
hashCodeandtoStringmethods of theKeyFrameclass
Aw man I swear I did it before! Thanks for the reminder I will fix that whenever I can
How are you testing if it is?
I just see in the code that it's not done, that's all
Sorry I am surviving on 3 hours of sleep so I somehow messed up the commit before this one that's why it had NOTHING IN IT Thankfully IntelliJ's local history option saved the day
I was so confused as to why you thought my code didn't work little did I know there was no code
Everything is fine now, but the only thing I don't like is that you haven't updated the keyframe size calculator
One reason is: this will unnecessarily increase the binary size, which is already at its size limit. I'll experiment with an alternative solution, if that doesn't work, I'll merge this.
KosmX probably wasn't referring to the size of the packets, you should never increase their size that way
Welp I don't understand this stuff which is why I decided not to touch networking at the start Doesn't your pull request also cause the same issue with the "binary size" or is that different somehow?
As for the size of the packets... Well, with the new emotecraft it's not a problem 🙃
Well this commit made things way more efficient so if new Emotecraft has a larger size limit then everything should be fine
Any updates? I am fine if this doesn't get merged if you have your own solution but just saying that I have seen a couple folks that think the 1.21 port hasn't happened yet because you haven't uploaded the new version on Modrinth and CurseForge
@KosmX does the new system for deserializing GeckoLib animations support easing arguments on 1.21? If not then I can get started porting this if you don't have other plans
Although considering how much you changed things I doubt there is much to salvage from here
blender does not support easing arguments, and geckolib animation import is apparently deprecated in playeranimator
That's the reason why this pr doesn't merge