minecraftPlayerAnimator icon indicating copy to clipboard operation
minecraftPlayerAnimator copied to clipboard

1.21.3 support fabric please

Open RaphyTwin opened this issue 1 year ago • 8 comments

Is your feature request related to a problem? Please describe. I wanted to use your awesome PlayerAnimator (it's great ngl) and I noticed that is not compatible with 1.21.3. So there are particularly two problems. #121 and the the getPlayerAnimLayer is not useable with the newer version (I think the class_742 has another name now but I'm not sure.

Describe the solution you'd like So I would highly appreciate a 1.21.3 Fabric port :). Thanks in advance!

RaphyTwin avatar Dec 19 '24 09:12 RaphyTwin

@RaphyTwin a port is already in progress by one of the contributors The main author of the mod isn't super active so I don't know when it will be released on the maven repository, but you can check out this fork and build it yourself in order to use it. (IT'S NOT READY YET!!!) Please close #121 because that error is simply because the library isn't released for 1.21.3 yet

ZigyTheBird avatar Dec 20 '24 00:12 ZigyTheBird

Whenever the port is ready it should end up on this maven repository first before KosmX's one:

        maven {
            name "dima_dencep"
            url "https://repo.redlance.org/public"
        }

ZigyTheBird avatar Dec 20 '24 00:12 ZigyTheBird

Okay, thank you very much :). Btw Merry Christmas

RaphyTwin avatar Dec 20 '24 10:12 RaphyTwin

Thanks :) Also I talked to KosmX and she decided that she wants to make the port on her own So forget everything I said, just wait very patiently!

ZigyTheBird avatar Dec 20 '24 14:12 ZigyTheBird

Ok, good to know. Only a question (because I want to know in what time range) how long will she approximately take to port it? Thanks in advance

RaphyTwin avatar Dec 20 '24 15:12 RaphyTwin

Don't know how long will it take, probably it will be done in a few days.

KosmX avatar Dec 20 '24 21:12 KosmX

@RaphyTwin you can build the 1.21.3 branch for a fabric version.
MC had a lot of changes in render API, and I also replaced a lot of mixins for better ones.

The first person animation is completely broken (as of now), but it can be used to port mods depending on this, as the API is already freezed and should be working

bendy-lib compatibility is also removed, the compatibility layer will be moved into bendy-lib (for easier maintenance)

if you don't use bendy, it won't affect you

KosmX avatar Dec 26 '24 11:12 KosmX

you can build the 1.21.3 branch

Maybe you could publish an alpha version on your maven? 🙏

dima-dencep avatar Dec 27 '24 07:12 dima-dencep