minecraftPlayerAnimator icon indicating copy to clipboard operation
minecraftPlayerAnimator copied to clipboard

Cape bug fixes... again.

Open ZigyTheBird opened this issue 1 year ago • 5 comments

Capes should look a lot better now during animations. Elytra are visually connected to the arms of the player rather than the torso so I decided not to use the same fix on that as well. I feel like being able to have an elytra bone and a cape bone in order to animate them would be pretty dope, but for now the current fix is good enough for me and probably for most people.

Also some cosmetics mods (Specifically this one) will break this fix regardless of the mixin priority The specified mod isn't open source so I guess it isn't our problem

ZigyTheBird avatar Sep 17 '24 12:09 ZigyTheBird

Oh and here is footage of the bug in question: https://youtu.be/Rgj8SnTCrVk

ZigyTheBird avatar Sep 17 '24 13:09 ZigyTheBird

Courtesy of user razorplay01 on discord

ZigyTheBird avatar Sep 17 '24 13:09 ZigyTheBird

Am I using @Local correctly here? I wish I knew about it sooner thanks a lot!

ZigyTheBird avatar Sep 17 '24 14:09 ZigyTheBird

Spent a little time testing this with Blender animations Everything seems to work pretty well!

ZigyTheBird avatar Sep 17 '24 15:09 ZigyTheBird

@KosmX fast-review pls 🙏

dima-dencep avatar Sep 26 '24 03:09 dima-dencep

dima-dencep helped me find some remaining issues with this PR Imma make this a draft until I fix those issues

ZigyTheBird avatar Oct 13 '24 13:10 ZigyTheBird

The cape now accounts for the torso's bend + fixed crouching breaking stuff Lots more testing still required but I already spent way more time than I could afford on this :p

ZigyTheBird avatar Oct 13 '24 20:10 ZigyTheBird

Didn't bother changing anything based on the left bend value since IDK how it works exactly

ZigyTheBird avatar Oct 16 '24 22:10 ZigyTheBird