Baal haTanya

Open pnemonic78 opened this issue 3 years ago • 3 comments

Jun 20 '22 20:06 pnemonic78

@pnemonic78 , I do not have access to my dev environment now, but given the symmetrical rise and set, is it ever different than chatzos calculated from sunrise to sunset?

Jun 20 '22 20:06 KosherJava

it's a calculation that was donated by someone else

Jun 21 '22 06:06 pnemonic78

@pnemonic78 , I ran some tests, and I am inclined to not add this. For Yerushalayim the max difference over the entire year is 0.26 seconds. For Lakewood it is 0.4 seconds,. Going to the extreme for Anchorage Alaska (at higher latitudes small changes can have a larger impact) this max diff is only 3.7 seconds (it is only > 1 second on 22 days of the year). Can you reach out to the code doner to see why he thinks that this is important? I am inclined to not accept this PR.

Jun 21 '22 21:06 KosherJava

@pnemonic78 , Given the comments above, and the recent v2.5.0 release that included astronomical chatzos, I am going to close this.

Aug 24 '23 17:08 KosherJava