Hugo Vacher
Hugo Vacher
> Just to be clear - that's also controlled by the new configuration flags, right? yeah, the configuration allows it for the last element, which a single argument/element technically is,...
@bbatsov I took a stab at documenting this option inside it's own Layout cops section, let me know what you think!
Addressed the comments 👍 One thing I'm not sure of, is the use of the `link:` the VSCode preview I used for the AsciiDoc doesn't handle links really other than...
> The simplest thing to do to check that `link:` works is just to install Antora locally and build the docs yourself. Btw, how did you manage to add this...
After some digging here is the more opinionated approach that I want to be push on our own rules. Let me know if that makes sense: Here are examples from...
@bbatsov with that additional context, do you think a more opinionated approach is worth pursuing, or should I clean up the doc and ship this approach instead?
Seems like the issue exists with Tuples too, tried to come up with some more examples here (order of the elements matters too): [→ View on sorbet.run](https://sorbet.run/#%23%20typed%3A%20true%0Aextend%20T%3A%3ASig%0A%0Asig%20%7B%20params%28param%3A%20T%3A%3AEnumerable%5BT.any%28String%2C%20%5BString%5D%29%5D%29.void%20%7D%0Adef%20foo%28param%29%3B%20end%0Afoo%28%5B%0A%20%20%22a%22%2C%0A%20%20%22b%22%2C%0A%20%20%5B%20%22c%22%20%5D%2C%0A%5D%29%0A%0Afoo%28%5B%0A%20%20%22a%22%2C%0A%20%20%22b%22%2C%0A%20%20%5B%20%22c%22%20%5D%2C%0A%20%20%5B%20%22d%22%20%5D%2C%0A%5D%29%0Afoo%28%5B%0A%20%20%5B%20%22c%22%20%5D%2C%0A%20%20%22a%22%2C%0A%20%20%22b%22%2C%0A%5D%29%0A%0Asig%20%7B%20params%28param%3A%20T%3A%3AEnumerable%5BT.any%28String%2C%20%7Bvalue%3A%20String%7D%29%5D%29.void%20%7D%0Adef%20bar%28param%29%3B%20end%0A%0Abar%28%5B%0A%20%20%22a%22%2C%0A%20%20%22b%22%2C%0A%20%20%7B%20value%3A%20%22c%22%20%7D%2C%0A%5D%29%0A%0Abar%28%5B%0A%20%20%22a%22%2C%0A%20%20%22b%22%2C%0A%20%20%7B%20value%3A%20%22c%22%20%7D%2C%0A%20%20%7B%20value%3A%20%22d%22%20%7D%2C%0A%5D%29%0A%0Abar%28%5B%0A%20%20%7B%20value%3A%20%22c%22%20%7D%2C%0A%20%20%22a%22%2C%0A%20%20%22b%22%2C%0A%5D%29)
@rafaelfranca Here is a draft PR: https://github.com/Shopify/shopify/pull/354457 > 45989 files inspected, 468482 offenses detected, 468296 offenses corrected So: Significant impact!
> Are there relevant sections in `README.md` that should be updated? Good point, does that update makes sense? https://github.com/Shopify/ruby-style-guide/pull/387/commits/e0082bb616852a0ff9395c4b51fd6fff2bbd9255
Updated this to depend on the changes made [in this PR](https://github.com/rubocop/rubocop/pull/10812), allowing us to keep a few exceptions to the new rules. This now will have to wait on the...