Korijn van Golen

Results 301 comments of Korijn van Golen

Controls are now thread safe (https://github.com/pygfx/pygfx/pull/55)

Well, first of all, we are quite heavily dependent on numpy, right? So there's that. However, you are right, we don't want to exclude so many users that quickly...

Try `camera.show_object`? Does that do the trick for you? https://github.com/pygfx/pygfx/blob/1b1bf5879b85b2a23aaa1026f44bdbcd812b8c80/pygfx/cameras/_base.py#L41-L59

Ah, I see. Image and Volume don't actually have any geometry (as in, 3d coordinates), so the bounding box is invalid. I'll open a PR to fix that.

That's what camera.show_object does! It takes the worldobject you pass in, retrieves the world space bounding box for the object and all its children, merges them and brings that into...

To be clear, the `camera.show_object` function now supports any object. However, the `Controller` classes don't have a `look_at` or `show_object`-like utility method just yet. That would be the remaining work...

> I think it would make more sense to have the `show_object()` method also on the controller instead. I think both need it, there are use cases for both.

I put "Translucent: accumulate each point using apha in the colormap" at the top because it's most important for our rendering purposes :)

Question: is the PBR model here compatible with blender PBR materials? It would be really cool if we can support the PBR material files you can download/purchase online for blender....