kubernetes-testing-framework icon indicating copy to clipboard operation
kubernetes-testing-framework copied to clipboard

Allow running integration and E2E tests in tests workflow for external contributors

Open czeslavo opened this issue 1 year ago • 5 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Problem Statement

KTF's integration and E2E tests require secrets to run (for the Kong license, and for access to GKE). That makes them fail for PRs from external contributors. We'd like to run them against every PR, therefore we need to come up with a solution to that.

Proposed Solution

~Trigger tests.yaml workflow on pull_request_target and ensure that in case a pull request author is an external contributor, the PR has to have a predefined label assigned (e.g. verified-for-running-ci) that would be assigned by a reviewer after ensuring that no potential secrets leak can happen due to the changes from PR.~

Implement the workflow described by Michael Heap in his blogpost.

Additional information

No response

Acceptance Criteria

  • [ ] Integration and E2E tests can be run against PRs submitted by external contributors

czeslavo avatar Mar 22 '23 12:03 czeslavo