kubernetes-ingress-controller icon indicating copy to clipboard operation
kubernetes-ingress-controller copied to clipboard

conformance: add support for GRPCRoute

Open tao12345666333 opened this issue 3 months ago • 4 comments

What this PR does / why we need it:

  • Changed the default protocol for processing GRPCRoute resources, allowing dynamic settings based on Gateway configuration. (more details: https://github.com/kubernetes-sigs/gateway-api/issues/2964 )
  • pass the GWAPI conformance test.

Which issue this PR fixes:

fixes: https://github.com/Kong/kubernetes-ingress-controller/issues/5705

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • [x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

tao12345666333 avatar Mar 28 '24 21:03 tao12345666333

  --- FAIL: TestGatewayConformance/GRPCExactMethodMatching (0.07s)
        --- PASS: TestGatewayConformance/GRPCExactMethodMatching/2_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/EchoThree'_should_receive_a_Unimplemented_(12) (0.01s)
        --- FAIL: TestGatewayConformance/GRPCExactMethodMatching/0_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCExactMethodMatching/1_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/EchoTwo'_should_go_to_grpc-infra-backend-v2 (30.00s)
    --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching (0.06s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/1_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Version:two}'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/7_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:green}'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/8_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:red}'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/9_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:yellow}'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- PASS: TestGatewayConformance/GRPCRouteHeaderMatching/10_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:purple}'_should_receive_a_Unimplemented_(12) (0.01s)
        --- PASS: TestGatewayConformance/GRPCRouteHeaderMatching/4_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:orange}'_should_receive_a_Unimplemented_(12) (0.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/6_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:blue}'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/3_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:blue,Version:two}'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- PASS: TestGatewayConformance/GRPCRouteHeaderMatching/5_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Some-Other-Header:one}'_should_receive_a_Unimplemented_(12) (0.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/2_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Color:orange,Version:two}'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteHeaderMatching/0_request_to_'/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_with_headers_'{Version:one}'_should_go_to_grpc-infra-backend-v1 (30.00s)
    --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching (1.29s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/1_request_to_'foo.bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v2 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/3_request_to_'boo.bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v3 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/7_request_to_'no.matching.host/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_receive_a_Unimplemented_(12) (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/5_request_to_'multiple.prefixes.foo.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v3 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/6_request_to_'foo.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_receive_a_Unimplemented_(12) (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/4_request_to_'multiple.prefixes.bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v3 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/0_request_to_'bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v1 (30.00s)
        --- FAIL: TestGatewayConformance/GRPCRouteListenerHostnameMatching/2_request_to_'baz.bar.com/gateway_api_conformance.echo_basic.grpcecho.GrpcEcho/Echo'_should_go_to_grpc-infra-backend-v3 (30.00s)

most of these tests have failed.

tao12345666333 avatar Mar 28 '24 21:03 tao12345666333

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@26a36a4). Click here to learn what that means.

:exclamation: Current head 91d2c60 differs from pull request most recent head fa23b77. Consider uploading reports for the commit fa23b77 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##             main   #5776   +/-   ##
======================================
  Coverage        ?   74.0%           
======================================
  Files           ?     176           
  Lines           ?   18185           
  Branches        ?       0           
======================================
  Hits            ?   13462           
  Misses          ?    3726           
  Partials        ?     997           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 28 '24 22:03 codecov[bot]

Blocked by #5918

tao12345666333 avatar May 10 '24 11:05 tao12345666333