kubernetes-ingress-controller icon indicating copy to clipboard operation
kubernetes-ingress-controller copied to clipboard

support license with DB backed Kong gateways

Open randmonkey opened this issue 1 year ago • 1 comments

What this PR does / why we need it:

Bump go-database-reconciler to enable sync of licenses with DB backed Kong gateways. Also enables the test on licenses in isolated integration tests.

Which issue this PR fixes:

fixes #5644

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

randmonkey avatar Feb 22 '24 09:02 randmonkey

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.0%. Comparing base (510c9ab) to head (b231646). Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5648     +/-   ##
=======================================
+ Coverage   73.8%   74.0%   +0.1%     
=======================================
  Files        176     176             
  Lines      18210   18212      +2     
=======================================
+ Hits       13455   13478     +23     
+ Misses      3753    3734     -19     
+ Partials    1002    1000      -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 22 '24 09:02 codecov[bot]

When will this finally be released?

wombat avatar May 06 '24 17:05 wombat

The backport to release/3.1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-5648-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 431a5bc44b8fcb5be448846a8687f7a5d5c4fe3b
# Push it to GitHub
git push --set-upstream origin backport-5648-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.x

Then, create a pull request where the base branch is release/3.1.x and the compare/head branch is backport-5648-to-release/3.1.x.

team-k8s-bot avatar May 09 '24 03:05 team-k8s-bot