kongponents icon indicating copy to clipboard operation
kongponents copied to clipboard

refactor: remove axios dependency

Open adamdehaven opened this issue 1 year ago • 1 comments

Summary

Addresses #817 by emulating Axios typings for our implementation of useRequest so that we can remove Axios as a dependency and peerDependency.

Unsure if we want to go this route.


PR Checklist

  • [x] Does not introduce dependencies
  • [x] Functional: all changes do not break existing APIs and if so, bump major version.
  • [x] Tests pass: check the output of yarn test packages/<Kongponent>
  • [x] Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • [x] Framework style: abides by the essential rules in Vue's style guide
  • [x] Cleanliness: does not have formatting issues, unused code (e.g., console.logs), or leftover comments
  • [ ] Docs: includes a technically accurate README, uses JSDOC where appropriate

adamdehaven avatar Oct 07 '22 12:10 adamdehaven

Deploy Preview for kongponents ready!

Name Link
Latest commit 603c15796b52f829d0caf49e7d4027ae5f89297e
Latest deploy log https://app.netlify.com/sites/kongponents/deploys/634020da0f5bd60009576ed8
Deploy Preview https://deploy-preview-818--kongponents.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 07 '22 12:10 netlify[bot]