kong icon indicating copy to clipboard operation
kong copied to clipboard

Published 20 hours ago • verified publisher icon Kong

chore(error_handlers): define response message for trace method 405 error status code

Open liverpool8056 opened this issue 3 years ago • 3 comments

Summary

When nginx blocks request with trace method from client, it hits the default error message in kong which is "The upstream server responded with 405", it is a little ambiguous. Actually the request doesn't reach upstream. Define a detail message "Method not allowed" for 405 status code.

liverpool8056 avatar Sep 20 '22 03:09 liverpool8056

@liverpool8056 Could you add a test case for this PR?

dndx avatar Sep 21 '22 00:09 dndx

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 21 '22 03:09 CLAassistant

@dndx So sorrrrrrry for missing test case, and thank you for helping me to correct it, I added the test case in the new commit.

liverpool8056 avatar Sep 21 '22 05:09 liverpool8056

Should we add an entry in changelog?

chronolaw avatar Oct 10 '22 04:10 chronolaw

Due to PR #9513, we should rebase the PR and change the index from string to number.

chronolaw avatar Oct 26 '22 09:10 chronolaw

@chronolaw already done

liverpool8056 avatar Oct 27 '22 03:10 liverpool8056

pinging @fffonion for merge.

hbagdi avatar Oct 27 '22 04:10 hbagdi