kong icon indicating copy to clipboard operation
kong copied to clipboard

feat(response-ratelimiting) redis ssl

Open dominikkukacka opened this issue 2 years ago • 5 comments

Summary

Adds flags to the response-ratelimiter for redis_ssl along with server_name for sni support. I basically copied over the changes from the rate-limiting plugin

dominikkukacka avatar Mar 25 '22 12:03 dominikkukacka

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 25 '22 13:03 CLAassistant

@dominikkukacka could you add related tests?

mayocream avatar Mar 25 '22 16:03 mayocream

@mayocream I certainly would, but I am not sure where. I can't find any other test specifically for plugins. I also saw no tests added for the same change in the rate-limit plugging so I stopped looking :)

My other problem is I can't compile Kong at all (I am on macOS but I also tried on Ubuntu) If the tests are running on CI I am still happy to add them but I would need you to point me to the location where I should implement them.

dominikkukacka avatar Mar 26 '22 07:03 dominikkukacka

@ADD-SP Hey, I tried my best to "copy over" the changes needed. I can't run the test suit locally so I hope there was no mistake. Will the test run in CI now?

dominikkukacka avatar Apr 07 '22 07:04 dominikkukacka

Is there anything I can help with?

dominikkukacka avatar Apr 12 '22 09:04 dominikkukacka

🥳 🎉

dominikkukacka avatar Nov 18 '22 07:11 dominikkukacka