kong
kong copied to clipboard
feat(response-ratelimiting) redis ssl
Summary
Adds flags to the response-ratelimiter for redis_ssl along with server_name for sni support. I basically copied over the changes from the rate-limiting plugin
@dominikkukacka could you add related tests?
@mayocream I certainly would, but I am not sure where. I can't find any other test specifically for plugins. I also saw no tests added for the same change in the rate-limit plugging so I stopped looking :)
My other problem is I can't compile Kong at all (I am on macOS but I also tried on Ubuntu) If the tests are running on CI I am still happy to add them but I would need you to point me to the location where I should implement them.
@ADD-SP Hey, I tried my best to "copy over" the changes needed. I can't run the test suit locally so I hope there was no mistake. Will the test run in CI now?
Is there anything I can help with?
🥳 🎉