kong icon indicating copy to clipboard operation
kong copied to clipboard

feat(prometheus): Include tags in metrics labels

Open carnei-ro opened this issue 2 years ago • 4 comments

Moving https://github.com/Kong/kong-plugin-prometheus/pull/149 to here

closes https://github.com/Kong/kong/issues/7678

carnei-ro avatar Sep 06 '21 16:09 carnei-ro

how this going

rmrf avatar Dec 22 '21 09:12 rmrf

@carnei-ro hi, any updates?

mayocream avatar Jan 12 '22 12:01 mayocream

hey guys, I'm not really sure why some tests are failing - need help

carnei-ro avatar Jan 24 '22 19:01 carnei-ro

Hi @carnei-ro

IMO, I don't think this behavior should be included in promethues plugin officially.

  1. We might want to avoid adding empty labels like service_tags="",route_tags="" by default
  2. Don't overuse labels, cardinality can be very large

ref:

  • https://github.com/prometheus/consul_exporter/issues/45

mayocream avatar Feb 21 '22 11:02 mayocream

We won't be able to accept this contribution at this point. The cardinality issues in the plugin have been plaguing Kong's performance for quite some time. Please revisit this change in 6 months.

hbagdi avatar Oct 25 '22 22:10 hbagdi