kong icon indicating copy to clipboard operation
kong copied to clipboard

feat(tracked-periods) resp ratelimiting persist only tracked periods

Open Simarn opened this issue 5 years ago • 6 comments

Summary

Plugin response-ratelimiting persist in database each calls value for all following periods : second, minute, hour, day, month, year. For minimize database size impact, only persist tracked periods. Take all limits and track only periods which have a limit.

Full changelog

  • Response ratelimiting plugin now persist only tracked periods

Issues resolved

Fix https://github.com/Kong/kong/issues/6413

Simarn avatar Oct 01 '20 15:10 Simarn

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 01 '20 15:10 CLAassistant

@Simarn Yay, thanks for this! I retargeted your PR to Kong's next branch, where we put new features. Can you run the following locally to update your PR?

git checkout next
git pull
git checkout feat/response-ratelimiting-tracked-period
git rebase next
git push --force

Please also follow the link to sign the Contributor License Agreement — also, looks like the email you used for the commit is different from the one in your Github account (this link has more info): you may want to register the additional email in your Github settings, or change the commit itself with git commit --amend --author="Your Name <[email protected]>" and git push --force.

hishamhm avatar Oct 01 '20 16:10 hishamhm

@hishamhm I follow your suggests, rebase on next and sign CLA. Tests failed seem to be not related to developments.

Simarn avatar Oct 06 '20 12:10 Simarn

@Simarn I went ahead and rebased this to latest next and force pushed it. Let's see if we get tests green.

bungle avatar Nov 20 '20 10:11 bungle

@bungle rebase works, all tests are fixed.

Simarn avatar Nov 23 '20 09:11 Simarn

Hello there, anything blocking the merge of this PR?

Gui13 avatar Mar 29 '21 15:03 Gui13

@Simarn Are you still interested in getting this to the finish line?

hbagdi avatar Oct 25 '22 21:10 hbagdi

@hbagdi yes i do. This PR is still waiting an approving review, anything blocking this pr?

Simarn avatar Oct 26 '22 07:10 Simarn

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 28 '22 23:12 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 14 '23 05:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 09 '23 07:03 stale[bot]