feat(tracked-periods) resp ratelimiting persist only tracked periods
Summary
Plugin response-ratelimiting persist in database each calls value for all following periods : second, minute, hour, day, month, year. For minimize database size impact, only persist tracked periods. Take all limits and track only periods which have a limit.
Full changelog
- Response ratelimiting plugin now persist only tracked periods
Issues resolved
Fix https://github.com/Kong/kong/issues/6413
@Simarn Yay, thanks for this! I retargeted your PR to Kong's next branch, where we put new features. Can you run the following locally to update your PR?
git checkout next
git pull
git checkout feat/response-ratelimiting-tracked-period
git rebase next
git push --force
Please also follow the link to sign the Contributor License Agreement — also, looks like the email you used for the commit is different from the one in your Github account (this link has more info): you may want to register the additional email in your Github settings, or change the commit itself with git commit --amend --author="Your Name <[email protected]>" and git push --force.
@hishamhm I follow your suggests, rebase on next and sign CLA. Tests failed seem to be not related to developments.
@Simarn I went ahead and rebased this to latest next and force pushed it. Let's see if we get tests green.
@bungle rebase works, all tests are fixed.
Hello there, anything blocking the merge of this PR?
@Simarn Are you still interested in getting this to the finish line?
@hbagdi yes i do. This PR is still waiting an approving review, anything blocking this pr?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.