kong icon indicating copy to clipboard operation
kong copied to clipboard

fix(ai-proxy): (Bedrock)(Gemini)(AG-154) fixed tools-functions calls coming back empty

Open tysoekong opened this issue 1 year ago • 2 comments

Summary

  • Fixes Bedrock, Gemini function calling in AI-Proxy system (AG-154)
  • Fixes "image_url" type message not working in Bedrock (AG-155)

Checklist

  • [ ] The Pull Request has tests
  • [x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

AG-154 AG-155

tysoekong avatar Oct 16 '24 08:10 tysoekong

@fffonion @subnetmarco Let's go

tysoekong avatar Oct 16 '24 15:10 tysoekong

spec/03-plugins/39-ai-request-transformer/02-integration_spec.lua is a genuine failure. I never get this right first-go, argh.

I'll fix it...

tysoekong avatar Oct 16 '24 18:10 tysoekong

@oowl I am on it

tysoekong avatar Nov 12 '24 15:11 tysoekong

@oowl Added tests

tysoekong avatar Nov 13 '24 03:11 tysoekong

@oowl @fffonion ready?

tysoekong avatar Nov 14 '24 16:11 tysoekong

@tysoekong I've done the rebase, and will merge in order 👍

fffonion avatar Nov 20 '24 08:11 fffonion

cherry-pick in https://github.com/Kong/kong-ee/pull/10757

fffonion avatar Nov 25 '24 09:11 fffonion

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13760-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13760-to-master-to-upstream
git checkout -b cherry-pick-13760-to-master-to-upstream
ancref=$(git merge-base c5199ff0c386bc8091273c8a99d6760eb382f102 e659e37b9832fd57aa970545244dec76d4b23210)
git cherry-pick -x $ancref..e659e37b9832fd57aa970545244dec76d4b23210

team-gateway-bot avatar Nov 25 '24 09:11 team-gateway-bot

Backport failed for release/3.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.8.x
git worktree add -d .worktree/backport-13760-to-release/3.8.x origin/release/3.8.x
cd .worktree/backport-13760-to-release/3.8.x
git switch --create backport-13760-to-release/3.8.x
git cherry-pick -x e5f5ca82a96fd860283580d2c1680580909c842e 042848703e56fef53b58b9fa49bf4c38b0b4035f 720ab027a02078ddafe04eb2cdceba799405c81f d19edcfea9fdfaf7733fe4cfeb3df81a8d5b9f27 db9d6ae7a9987e3a29efd20ad66122d3b834813e

team-gateway-bot avatar Nov 25 '24 09:11 team-gateway-bot