kong icon indicating copy to clipboard operation
kong copied to clipboard

feat(plugin/response-transformer): added support for json_body rename

Open zhongweikang opened this issue 10 months ago • 5 comments

Summary

detail here: https://github.com/Kong/kong/discussions/12824.

Checklist

  • [x] The Pull Request has tests
  • [x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [ ] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

zhongweikang avatar Apr 19 '24 10:04 zhongweikang

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 19 '24 10:04 CLAassistant

Hey @bungle. Can you help me approval this workflow? I added new fields to removed_fields.lua and added a test for this. Thank you so much.

zhongweikang avatar Apr 28 '24 15:04 zhongweikang

Hey @chronolaw, I read the error logs of the test runner, but I didn't find anything related to my changes. could you help me with that?

zhongweikang avatar May 07 '24 08:05 zhongweikang

Hey @chronolaw, I read the error logs of the test runner, but I didn't find anything related to my changes. could you help me with that?

Some test cases are flaky, rerun the tests can make them green.

chronolaw avatar May 07 '24 08:05 chronolaw

@samugi @jschmid1 could you help to take a look at this PR?

zhongweikang avatar May 28 '24 16:05 zhongweikang

closing was unintentional! I intended to resolve conflicts but the force-push resulted in the PR to auto-close

samugi avatar May 31 '24 17:05 samugi

closing was unintentional! I intended to resolve conflicts but the force-push resulted in the PR to auto-close

@samugi So I should start a new PR?

zhongweikang avatar May 31 '24 17:05 zhongweikang

@zhongweikang reopened here: https://github.com/Kong/kong/pull/13131 so sorry about my mistake :( and thank you for the contribution!

samugi avatar May 31 '24 17:05 samugi