kong
kong copied to clipboard
chore(github): add conventional commits check
Summary
This commit adds action-conventional-commits gh action
Checklist
- [ ] ~N/A~ The Pull Request has tests
- [ ] ~N/A~ A changelog file has been created under
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.md - [ ] ~N/A~ There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE
Full changelog
N/A
Issue reference
KAG-1290
Oh! Thanks @dndx for pointing that out!
Let me make sure I understood you correctly. What we care about is following Conventional Commits standards on master
branch. However when you Squash & Merge a PR, there's a new commit created, so it does not really matter whether the PR followed CC standards or not, because all of those commits will become the new commit?
We could try to consider enforcing PR title standards, because from what I can see GH uses PR title as a placeholder for the Squash&Merge commit message. However since it's still can be edited by a user, I don't think it makes sense to enforce it like that anyway.
So I guess we should just drop this PR and update the ticket with proper message.
Does it sound ok? 👍 / 👎 ?