feat(response-ratelimiting): add support for secret rotation with redis connection

Open bungle opened this issue 2 years ago • 2 comments

Summary

Adds support for secret rotation for redis credentials in response-ratelimiting plugin.

Mar 28 '23 12:03 bungle

@bungle I have seen this PR was added to 3.3 milestones, And the code looks Okay. Why was this PR labeled draft?

Apr 25 '23 09:04 oowl

Moving this to 3.4, and perhaps abstract it a bit more.

May 02 '23 10:05 bungle

I'm going to remove this from the 3.4 milestone. We are too busy fixing the bugs we found on the "regular" (non-try-based) TTL code to expand the scope even more. Also, this PR has no tests.

Jul 17 '23 14:07 kikito

I'm approving this because (request-)ratelimiting has the same change and otherwise this would make both plugins iconsistent.

Sep 12 '23 08:09 kikito