insomnia icon indicating copy to clipboard operation
insomnia copied to clipboard
verified publisher icon Kong

feat: enable basic runner

Open ihexxa opened this issue 1 year ago • 3 comments

Background

This PR enables basic runner by commenting out some dependencies.

Changes

  • [x] Added runner, runner menu items
  • [x] Integrated runner to the request pane
  • [x] Updated timer to support updating step name in place
  • [x] Refactored sendAction to make it can be reused

image

Ref: INS-4197, INS-4222, INS-4223

ihexxa avatar Aug 14 '24 08:08 ihexxa

~~@ihexxa was running this locally and one thing I noticed is that when you just boot it up, and create a design doc, it restarts the app when navigating to the collection page. Please see the Loom link - https://www.loom.com/share/f6f851ca31964ff2b0bee118c28ecd63?sid=e9a9c9c3-4e18-4852-95b6-2f7c3bc84d6c~~

~~Steps to reproduce:~~ ~~1. run Insomnia locally~~ ~~2. create a design doc~~ ~~3. navigate to the collection page~~

~~Expected result:~~ ~~- it should be navigated to Collection page without restarting the app~~

~~Actual result:~~ ~~- it restarts the app~~ ~~- it stays in the Design page instead of navigating to Collection page~~

~~I wonder if this is related to this branch or not.~~

It happens in the latest dev as well

marckong avatar Aug 22 '24 16:08 marckong

@marckong Let me schedule a sync at sometime.

ihexxa avatar Aug 23 '24 03:08 ihexxa

Note: abstracts the send action in order to use different exception handling.

jackkav avatar Aug 26 '24 09:08 jackkav

@ihexxa is this one still needed or we can close it?

filfreire avatar Sep 02 '24 09:09 filfreire

@filfreire It is no longer needed, let me close it.

ihexxa avatar Sep 02 '24 10:09 ihexxa