insomnia icon indicating copy to clipboard operation
insomnia copied to clipboard

Published 20 hours ago • verified publisher icon Kong

feat: add customizable shortcut for toggling comment in editor

Open iamkhav opened this issue 1 year ago • 1 comments

Summary

Hey everyone, This PR allows customizing the shortcut for toggling comments. I personally couldn't use the default shortcut since I'm using a MacOS with DE keyboard layout. More detail in the linked threads.

Related to feature request https://github.com/Kong/insomnia/discussions/4112 Related to issue https://github.com/Kong/insomnia/issues/2018

iamkhav avatar Nov 30 '23 22:11 iamkhav

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 30 '23 22:11 CLAassistant

Hi @jackkav @gatzjames @filfreire, I'm pinging you directly because this PR has been open for some time.

Would you be able to give me an opinion on this?

I'm not a skilled TS person so I'm hoping for some hints on how this could be improved and whether tests are necessary.

iamkhav avatar Feb 23 '24 10:02 iamkhav

Closing as we will revisit hotkey configuration for the code editor all together

gatzjames avatar Jul 12 '24 11:07 gatzjames