insomnia icon indicating copy to clipboard operation
insomnia copied to clipboard

Published 20 hours ago • verified publisher icon Kong

Hitting "Escape" to close the "Manage Environments" modal doesn't save the new environment settings.

Open AustinTSchaffer opened this issue 1 year ago • 6 comments

Expected Behavior

You can hit Command+E or CTRL+E to open the "Manage Environments" model. Hitting "Escape" should close the "Manage Environments" modal, as well as save any changes that were made to the environment settings.

Actual Behavior

Currently, hitting "Escape" to close the "Manage Environments" modal only closes it and does not save the settings.

There does not appear to be a dedicated shortcut to close the modal, apart from "Escape" either. This means the only way to adjust settings is to hit "X" or "Close".

Reproduction Steps

  1. Open the "Manage Environments" modal
  2. Add a new key/value pair
  3. Hit "escape"
  4. Reopen the "Manage Environments" modal
  5. observe that the new key/value pair was not saved

Is there an existing issue for this?

Additional Information

Version: Insomnia 2023.2.0 Build date: 4/26/2023 OS: Darwin x64 22.4.0 Electron: 22.0.0 Node: 16.17.1 V8: 10.8.168.20-electron.0 Architecture: x64

Insomnia Version

2023.2.0

What operating system are you using?

macOS

Operating System Version

Darwin x64 22.4.0

Installation method

brew install --cask insomnia

Last Known Working Insomnia version

N/A

AustinTSchaffer avatar May 02 '23 18:05 AustinTSchaffer

Thanks for reporting this @AustinTSchaffer - I can also reproduce, we'll try to fix this in time for the next patch release 👍

filfreire avatar May 05 '23 13:05 filfreire

Thanks @filfreire!

AustinTSchaffer avatar May 07 '23 02:05 AustinTSchaffer

I'm on the below version, still cannot save environments.

Version: Insomnia 2023.5.8 Build date: 9/7/2023 OS: Darwin x64 22.6.0 Electron: 25.2.0 Node: 18.15.0 Node ABI: 116 V8: 11.4.183.23-electron.0 Architecture: x64

perttuzp10 avatar Sep 22 '23 09:09 perttuzp10

Any updates on this?

arminio avatar Oct 05 '23 01:10 arminio

Reproduceable with latest version. Really frustrating. Workaround is to click somewhere in the opened environment window and than click escape.

Version: Insomnia 8.4.0 Build date: 11/9/2023 OS: Windows_NT x64 10.0.19044 Electron: 27.0.3 Node: 18.17.1 Node ABI: 118 V8: 11.8.172.16-electron.0 Architecture: x64

IvoQA avatar Nov 10 '23 14:11 IvoQA

This seems to be resolved on the last develop version. Ticket should be closed

andrea-mauro avatar Mar 29 '24 07:03 andrea-mauro