docs.konghq.com
docs.konghq.com copied to clipboard
Feat/add privatelink docs
https://konghq.atlassian.net/browse/CSRE-2806
Description
Add docs page for privatelink.
Testing instructions
Preview link:
Checklist
- [x] Review label added
- [ ] Conditional version tags added, if applicable.
Deploy Preview for kongdocs ready!
| Name | Link |
|---|---|
| Latest commit | 9b5667f7827382a52512ab39221de8e530e112bd |
| Latest deploy log | https://app.netlify.com/sites/kongdocs/deploys/673c68c4de3dd7000882ba09 |
| Deploy Preview | https://deploy-preview-7771--kongdocs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
9 paths audited Performance: 94 (🟢 up 4 from production) Accessibility: 92 (no change from production) Best Practices: 98 (🟢 up 8 from production) SEO: 99 (no change from production) PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hi @healthy-pod, I've moved the section and made some structure/wording changes, can you take a look?
My understanding from the product brief is that it will eventually be possible to create private connections to other cloud providers, so it made sense to me to create a section for that and put the privatelink docs under it. Let me know what you think. Thanks!
@cloudjumpercat Thanks for your comments! When I started reviewing I also changed the HTML to markdown, but then I realized that it caused issues with the navtabs inside a step, so I put the HTML back 😄 do you know if there a better way to do this?
@cloudjumpercat Thanks for your comments! When I started reviewing I also changed the HTML to markdown, but then I realized that it caused issues with the navtabs inside a step, so I put the HTML back 😄 do you know if there a better way to do this?
@lmilan Good catch! I'm not sure why the tabs would be doing that, @lena-larionova or @fabianrbz, do you know why the markdown is causing problems with the tabs?
@lmilan @cloudjumpercat not that it might be related, but can you add a closing | to the tables?
the problem with the navtabs is probably the indentation.
if they are inside a list, they should be indented
if they are inside a list, they should be indented
@fabianrbz that worked, thank you! @cloudjumpercat I applied your suggestions, thanks!
@fabianrbz Could you help fix the failing smoke test? I updated the branch since I thought it might be an issue with the Kong Mesh 2.9 nav file, but that didn't fix it and I couldn't figure out what went wrong.
@cloudjumpercat we need to merge this one first. Or drop the submodule update from this one
I accidentally merged this early so I reverted it and created a new PR #8149
