docs.konghq.com icon indicating copy to clipboard operation
docs.konghq.com copied to clipboard

Feat/add privatelink docs

Open healthy-pod opened this issue 1 year ago • 7 comments

https://konghq.atlassian.net/browse/CSRE-2806

Description

Add docs page for privatelink.

Testing instructions

Preview link:

Checklist

healthy-pod avatar Aug 20 '24 00:08 healthy-pod

Deploy Preview for kongdocs ready!

Name Link
Latest commit 9b5667f7827382a52512ab39221de8e530e112bd
Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/673c68c4de3dd7000882ba09
Deploy Preview https://deploy-preview-7771--kongdocs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
9 paths audited
Performance: 94 (🟢 up 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 20 '24 00:08 netlify[bot]

Hi @healthy-pod, I've moved the section and made some structure/wording changes, can you take a look?

My understanding from the product brief is that it will eventually be possible to create private connections to other cloud providers, so it made sense to me to create a section for that and put the privatelink docs under it. Let me know what you think. Thanks!

lmilan avatar Sep 09 '24 14:09 lmilan

@cloudjumpercat Thanks for your comments! When I started reviewing I also changed the HTML to markdown, but then I realized that it caused issues with the navtabs inside a step, so I put the HTML back 😄 do you know if there a better way to do this?

lmilan avatar Sep 10 '24 08:09 lmilan

@cloudjumpercat Thanks for your comments! When I started reviewing I also changed the HTML to markdown, but then I realized that it caused issues with the navtabs inside a step, so I put the HTML back 😄 do you know if there a better way to do this?

@lmilan Good catch! I'm not sure why the tabs would be doing that, @lena-larionova or @fabianrbz, do you know why the markdown is causing problems with the tabs?

cloudjumpercat avatar Sep 10 '24 13:09 cloudjumpercat

@lmilan @cloudjumpercat not that it might be related, but can you add a closing | to the tables?

fabianrbz avatar Sep 10 '24 15:09 fabianrbz

the problem with the navtabs is probably the indentation.

if they are inside a list, they should be indented

fabianrbz avatar Sep 10 '24 15:09 fabianrbz

if they are inside a list, they should be indented

@fabianrbz that worked, thank you! @cloudjumpercat I applied your suggestions, thanks!

lmilan avatar Sep 10 '24 15:09 lmilan

@fabianrbz Could you help fix the failing smoke test? I updated the branch since I thought it might be an issue with the Kong Mesh 2.9 nav file, but that didn't fix it and I couldn't figure out what went wrong.

cloudjumpercat avatar Nov 08 '24 21:11 cloudjumpercat

@cloudjumpercat we need to merge this one first. Or drop the submodule update from this one

fabianrbz avatar Nov 11 '24 11:11 fabianrbz

I accidentally merged this early so I reverted it and created a new PR #8149

lmilan avatar Nov 19 '24 11:11 lmilan