docs.konghq.com icon indicating copy to clipboard operation
docs.konghq.com copied to clipboard

Mesh security recommendations

Open lahabana opened this issue 10 months ago • 4 comments

Description

Testing instructions

Preview link:

Checklist

For example, if this change is for an upcoming 3.6 release, enclose your content in {% if_version gte:3.6.x %} <content> {% endif_version %} tags (or if_plugin_version tags for plugins).

Use any of the following keys:

  • gte:<version> - greater than or equal to a specific version
  • lte:<version> - less than or equal to a specific version
  • eq:<version> - exactly equal to a specific version

You can do the same for older versions.

lahabana avatar Apr 04 '24 16:04 lahabana

Deploy Preview for kongdocs ready!

Name Link
Latest commit dbf890013592d8722b79c2e614289018b9f2705d
Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/669e0f3063d227000865084a
Deploy Preview https://deploy-preview-7173--kongdocs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
9 paths audited
Performance: 92 (🔴 down 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 04 '24 16:04 netlify[bot]

07:40:26 vite.1   | TypeError: Invalid URL
07:40:26 vite.1   |     at new URL (node:internal/url:775:[36](https://github.com/Kong/docs.konghq.com/actions/runs/8558528024/job/23476684430?pr=7173#step:12:37))
07:40:26 vite.1   |     at setHostHeader (/home/runner/work/docs.konghq.com/docs.konghq.com/vite.config.ts:50:16)
07:40:26 vite.1   |     at Object.configure (/home/runner/work/docs.konghq.com/docs.konghq.com/vite.config.ts:96:13)
07:40:26 vite.1   |     at file:///home/runner/work/docs.konghq.com/docs.konghq.com/node_modules/vite/dist/node/chunks/dep-BBHrJRja.js:63284:18
07:40:26 vite.1   |     at Array.forEach (<anonymous>)
07:[40](https://github.com/Kong/docs.konghq.com/actions/runs/8558528024/job/23476684430?pr=7173#step:12:41):26 vite.1   |     at proxyMiddleware (file:///home/runner/work/docs.konghq.com/docs.konghq.com/node_modules/vite/dist/node/chunks/dep-BBHrJRja.js:63274:26)
07:40:26 vite.1   |     at _createServer (file:///home/runner/work/docs.konghq.com/docs.konghq.com/node_modules/vite/dist/node/chunks/dep-BBHrJRja.js:64825:25)
07:40:26 vite.1   |     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
07:40:26 vite.1   |     at async CAC.<anonymous> (file:///home/runner/work/docs.konghq.com/docs.konghq.com/node_modules/vite/dist/node/cli.js:762:24)

@fabianrbz I guess this is due to my cross link to Konnect's docs. Do you know how I should write this to make the test pass?

lahabana avatar Apr 08 '24 14:04 lahabana

@fabianrbz I ran this locally and all tests passed. What could be the issue?

mheap avatar May 07 '24 16:05 mheap

The issue is that it comes from a fork, and the VITE_PORTAL_API_URL doesn't exist in the forks env.

fabianrbz avatar May 07 '24 17:05 fabianrbz