komodo-wallet-desktop
komodo-wallet-desktop copied to clipboard
KomodoPlatform
Add addresbook protocols
Closes https://github.com/KomodoPlatform/atomicDEX-Desktop/issues/1337
To Test:
- login
- Go to wallet page and copy address for an EMV token from the new protocols (e.g. PLG20, AVX20, FTM20)
- Go to addressbook go to add a new address
- Toggle on "use standard network address" and select the network type
- add address (testing validation)
- save changes
- confirm no missing icons.
Known issues Segwit compatible coins are appearing twice in the individual coins menu https://github.com/KomodoPlatform/atomicDEX-Desktop/issues/2285
@smk762 when I want to add LTC address to Address book I see two Litecoin UTXO one of this Segwit, right?
Yes - that issue was identified by not yet resolved https://github.com/KomodoPlatform/atomicDEX-Desktop/issues/2285
Found another bug in this PR - when editing entries for newer protocols, it reverts to "new address" form.
https://github.com/KomodoPlatform/atomicDEX-Desktop/assets/35845239/8457c4fe-e621-49ca-b0b7-87e6a81c30e9
This PR will be held back for 0.5.9 so this and other identified issues can be resolved.
Another one bug Addresses disappeared for 1st entry in address book. Steps:
- Add few contacts to to address books and add address for these contacts
- Go to Wallet, open any asset and click send.
- Close send form
- Go to Address book check 1st contact
Result: 1st contact does not have addresses. After app reload addresses displayed again
@kivqa @smk762 tested and happened the same to me. btw as is in the test description icons are okay.
