komodo-wallet-desktop icon indicating copy to clipboard operation
komodo-wallet-desktop copied to clipboard

Published 20 hours ago • verified publisher icon KomodoPlatform

Make tx history better again

Open SylEze opened this issue 2 years ago • 3 comments

Closes #1849

SylEze avatar Jul 29 '22 11:07 SylEze

@SylEze old bug returned: if you switch between assets fast, then history for another coin displaying (in video below history from KMD is displaying for BCH)

https://user-images.githubusercontent.com/24797699/182200729-cfede93c-750a-43f4-b0cc-5e381697fd40.mov

tonymorony avatar Aug 01 '22 16:08 tonymorony

It seems now that when I switch quick in the coins menu it just gets stuck on "fetching transactions"

smk762 avatar Aug 04 '22 11:08 smk762

Yeah, right now it's totally broken: if you starting switch fast it's became in "fetching transactions" spinner status until I restart the app

https://user-images.githubusercontent.com/24797699/183542369-557fa71c-25a6-4308-9335-a305094e1e16.mov

tonymorony avatar Aug 09 '22 01:08 tonymorony

Please retest this PR

(cc. @Canialon @tonymorony @smk762)

ghost avatar Sep 14 '22 17:09 ghost

This seems to be working here in terms of the current history on wallet page for the correct coin without things locking up. I can;t see history for anything that is not a utxo coin though.

@Canialon @SirSevenG please note that when testing this PR with an existing wallet, it might crash due to json conflicts. This issue has been resolved elsewhere, but you might need to manually delete your wallet's local coins file.

smk762 avatar Sep 15 '22 12:09 smk762

Was able to see non-utxo coins transaction history.

There's visual bug when switching coins in Wallet, light theme provides better visibility of it: Screenshot 2022-09-16 040109

Just switch a few coins view and see how coin-selection panel changes highlights here.

Just synced again with SLP PR which contains some enabling coin fixes so it might fix your problem Can you please try again @SirSevenG ?

ghost avatar Sep 23 '22 10:09 ghost

Looks good here too :+1: I"ll wait for SLP branch to merge, then approve / merge this one.

smk762 avatar Sep 23 '22 11:09 smk762

this time I have reproduced this dug XD

100% way to reproduce (works for me on mac and windows):

  1. create new or import wallet
  2. click add assests
  3. choose select all -> enable
  4. wait until all coins are activated
  5. go to wallet tab and choose one coin by one
image

Tab hover effect also breaks image

Looks like it is not this branch bag, I was able to reproduce it on other branches. So will create an issue

Canialon avatar Sep 23 '22 14:09 Canialon

Good catch @Canialon ! Confirmed here by manually deleting wallet's Transaction json files in /.atomic_qt/mm2/DB/<walletID_hash>/TRANSACTIONS and logging in again. @SylEze it looks like previous selection reverts to "clicked" state for highlight instead of default (no highlight). I'll take a look this weekend and see if I can resolve.

smk762 avatar Sep 23 '22 14:09 smk762

Will be fixed in another PR since it's unrelated with the work done here: https://github.com/KomodoPlatform/atomicDEX-Desktop/pull/1985

this time I have reproduced this dug XD 100% way to reproduce (works for me on mac and windows):

  1. create new or import wallet
  2. click add assests
  3. choose select all -> enable
  4. wait until all coins are activated
  5. go to wallet tab and choose one coin by one
image Tab hover effect also breaks image

Looks like it is not this branch bag, I was able to reproduce it on other branches. ~ So will create an issue ~

ghost avatar Sep 27 '22 10:09 ghost