atomicDEX-API icon indicating copy to clipboard operation
atomicDEX-API copied to clipboard

Request balance and utxos for both P2KH and P2PKH script hashes from Electrum.

Open artemii235 opened this issue 5 years ago • 5 comments

As of now MM2 uses only P2PKH script hash so it might get incorrect balance and utxos from Electrum if the address has P2PK utxos.

https://discordapp.com/channels/412898016371015680/449950331577565194/756147006237573150

https://github.com/kyuupichan/electrumx/issues/818#issuecomment-633497973

artemii235 avatar Sep 18 '20 06:09 artemii235

We should also consider implementing the same for Native mode.

artemii235 avatar Jan 13 '21 10:01 artemii235

I can confirm this happens with Coinstakes too. (Blackcoin, PoSv3)

michelvankessel avatar Mar 02 '21 23:03 michelvankessel

would solving this issue also make it possible to see and spend the timelocked transactions from TKL? the vout of such a tx in question looks like this

    {
      "value": 62854.37046316,
      "valueSat": 6285437046316,
      "n": 1,
      "scriptPubKey": {
        "asm": "1655251200 OP_NOP2 OP_DROP OP_DUP OP_HASH160 4d2a1a4748205d088a382f2023cad8ea6403f6cc OP_EQUALVERIFY OP_CHECKSIG",
        "hex": "040021a962b17576a9144d2a1a4748205d088a382f2023cad8ea6403f6cc88ac",
        "type": "pubkeyhash"
      }
    }

if so, then it would be nice if he could prioritize this, some TKL rewards were unlocked today and can not be seen or spent on ADEX Desktop with electrums

cipig avatar Jun 15 '22 18:06 cipig

@shamardy @ozkanonur can we please implement this? I just encountered the same discrepancy between explorer balance and API balance related to this.

smk762 avatar Apr 28 '23 08:04 smk762

@shamardy @ozkanonur can we please implement this?

Sure, I can take a look at it next week.

shamardy avatar Apr 28 '23 08:04 shamardy

Fixed here https://github.com/KomodoPlatform/komodo-defi-framework/pull/2053

shamardy avatar Jul 29 '24 15:07 shamardy