atomicDEX-API icon indicating copy to clipboard operation
atomicDEX-API copied to clipboard

macos integration tests job failing

Open shamardy opened this issue 4 months ago • 4 comments

https://github.com/KomodoPlatform/komodo-defi-framework/actions/runs/17049261583/job/48332671816

shamardy avatar Aug 19 '25 16:08 shamardy

Looks like fetch-params-alt.sh failed to call sha256sum:

Download successful!
usage: sha256sum [-bctwz] [files ...]
Error: Process completed with exit code 1.

Just tried fetch-params-alt.sh on latest macos but it worked okay, hmm

dimxy avatar Aug 19 '25 17:08 dimxy

We should check sha256sum version and see if it's not compatible with fetch-params-alt.sh (which is the case most likely).

onur-ozkan avatar Aug 19 '25 18:08 onur-ozkan

https://github.com/KomodoPlatform/komodo/blob/master/zcutil/fetch-params-alt.sh#L19 checks if sha256sum command is available and if it isn't, uses shasum. the script assumes sha256sum is not available on MacOS. is it somehow available on the MacOS runner we use?

gcharang avatar Aug 19 '25 21:08 gcharang

It should be available as it prints

usage: sha256sum [-bctwz] [files ...] Error: Process completed with exit code 1.

It just has different usage than what the script is trying to do. We use shasum on our CI for MacOS btw, maybe that script should do that too.

onur-ozkan avatar Aug 20 '25 06:08 onur-ozkan