atomicDEX-API
atomicDEX-API copied to clipboard
fix(p2pk): show P2PK balance
This makes it so we don't auto-convert P2PK addresses to P2PKH addresses, thus we can query them for balances if they have any.
Also refactors utxo::output_script()
to auto detect the address type without the need for a keys::Type
flag.
Fixes #720
Missing unit tests for the balance addition. Verified it's working as expected with manual tests though.
@mariocynicys can you please fix failing docker tests compilation by running this command cargo test --test 'docker_tests_main' --features run-docker-tests
and checking the errors. You can wait for https://github.com/KomodoPlatform/komodo-defi-framework/pull/1960 to be merged first but don't forget to check these errors after that.
@mariocynicys As discussed, we should also implement P2PK
outputs spending in this PR. You should wait for the merge of the conflicting PR first for this too.
The changes made up till now (showing p2pk balance) are reviewable. p2pk spending isn't added yet.
update: removed the under review
status so the CI doesn't complain, still reviewable though.
@mariocynicys please fix conflicts in this PR so that we can review it.
@shamardy, sorry, missed the last suggestions. Done now.
There seems to be some of this pattern in this test file though. Let me try to handle these as well in this PR.
@smk762 if you have time, can you please check if your comment here https://github.com/KomodoPlatform/komodo-defi-framework/issues/720#issuecomment-1527182643 is resolved? If I merged it before that, you can check this in dev :)