Add Unity Menubar support

[Mystic-Mirage]

Hello!

Since Komodo Edit 8.5 the patching of Mozilla is the only way to support Unity Menubar integration due to Ubuntu upstream changes.

During two years of using this patch there are no problems found in other DEs. Tested on Gnome, Gnome Flashback, KDE, XFCE, LXDE, Cinnamon and Mint.

The unity-menubar.patch used unchanged from code.launchpad.net/~mozillateam/firefox/firefox-trunk.head. It released under Mozilla Public License version 2.0.

Maybe it is time to integrate this patch to Komodo Edit mainline? And it is the way to integrate this patch to Komodo IDE for those who need it.

---

This change is 

[Defman21]

:+1: for this PR. Really want to see the appmenu in the menubar of Unity DE.

[Naatan]

This is great! Thanks @Mystic-Mirage! I won't integrate it right away as some testing will be required, but I'll definitely ensure we try this for Komodo 10.

[mitchell-as]

The effects of this patch will not show up in Komodo 10's new UI, so I'm closing this PR. Thanks for your efforts though!

[garak]

If you can consider to re-open this issue, I can say that I'm using Komodo 10 with global menu. I just applied files extracted from @Mystic-Mirage PPA over my Komodo IDE 10 installation.

[th3coop]

ref: http://forum.komodoide.com/t/komodo-10-menu/2736/7?u=careyh

[Defman21]

You'd change the milestone.

[awilkins]

For reference, which files do you need to merge from the patched "Edit" .deb to get it working in the IDE?

[garak]

@awilkins see https://github.com/garak/Komodo-IDE-Ubuntu-global-menu

[awilkins]

That seems to be instructions for the version that was an extension, rather than a direct patch.

I managed it last night by comparing the PPA version of Edit with the latest IDE - PPA uses a slightly newer (and patched) version of Mozilla code, by copying most of the libs and binaries from the root of the Mozilla folder plus some of the stylesheets (that hide menus when the dbus integration is running) I also got it to work. Viewing the patch and grepping for strings in the non compiled files was instructive.

[garak]

If you got different instructions to get it working, what about sharing them?

[Defman21]

@garak

http://forum.komodoide.com/t/unity-menubar-overwrite-error/3063/7?u=defman https://defman.me/blog/globalmenu-4-life/

[mitchell-as]

I've applied this patch and tested in Ubuntu. Here are my initial impressions:

• Alt+F or any other menubar shortcut no longer works out of the box. The hamburger menu is the only way to get menu access.
• Right-click > Show Menubar on the titlebar does nothing but hide the hamburger menu. I don't have access to any menu at this point.
• I must enable native window decorations in order to be able to Alt+F or similar to get a menu.

I spoke with @Naatan about this and he wants to see if he can make this work more intuitively. Until he manages to do so, I cannot recommend merging this PR. Assigning to him in the meantime.

[Defman21]

Alt+F or any other menubar shortcut no longer works out of the box. The hamburger menu is the only way to get menu access.

Works fine for me. When I hold Alt, global menu items highlights accessible keys. (Alt+F opens File menu).

I must enable native window decorations in order to be able to Alt+F or similar to get a menu.

Works for me in both situations.

Right-click > Show Menubar on the titlebar does nothing but hide the hamburger menu. I don't have access to any menu at this point.

Yep, this one doesn't work anymore.

However, I've applied this patch by copying some files from the global menu patch (from KomodoEdit PPA).. I assume this could give different results.

[mitchell-as]

@Defman21 You're right that if you maximize the Komodo window, menu shortcuts work out of the box. I was starting in window'ed mode.

[Defman21]

Hmm, it works fine for me even in windowed mode. With native or without native decorations. We would need more testers for that.

[mitchell-as]

Perhaps they are related to your custom patches then. I only have only applied the PR.

[Defman21]

@Mystic-Mirage are there any changes between mine method of getting global menu support and directly applying this patch?

[Defman21]

Btw I can test this patch but I don't know how (I've copied unity-menubar.patch to Komodo source/mozilla/patches-new/mozilla-35.0/gtk/). I have to python build.py distclean all?

[mitchell-as]

@Defman21 Yes, that's it. And then sit tight for an hour or two :)

[Defman21]

About 40 mins for me :) Thanks.

[Defman21]

Huh, looks like python build.py all works fine. I don't have to re-download Mozilla core again.

[Naatan]

I think you will need python build.py clean all. Otherwise it's using the cache and likely won't apply all the patches.

[Defman21]

Okay, thanks.

[Mystic-Mirage]

@Defman21 Hi! If you have copied only files listed bellow, there is no difference between methods because that patch affects only these files:

./mozilla/chrome/toolkit/content/global/xul.css
./mozilla/chrome/toolkit/content/global/bindings/popup.xml
./mozilla/greprefs.js
./mozilla/libxul.so

[Defman21]

@mitchell-as were you using Docker for building?

[mitchell-as]

@Defman21 No. Native Ubuntu 14.04.

[Defman21]

Thanks. I've reported #2061 for that.