KomodoEdit icon indicating copy to clipboard operation
KomodoEdit copied to clipboard

Misc: use xdg-open for the show in finder command

Open Defman21 opened this issue 8 years ago • 5 comments

Signed-off-by: Defman21 [email protected]

Fixed #250

Defman21 avatar May 04 '17 17:05 Defman21

If you do use xdg-open; there's no need to keep the Nautilus/Doplhin options. As every Linux DE out there follows free-desktop standards and so by using xdg-open it will open the default file manager no matter which DE you're using

bilelmoussaoui avatar Jun 17 '17 00:06 bilelmoussaoui

Why did you remove the fallbacks? Those are still very relevant.

Edit: just read @bil-elmoussaoui 's response. I don't agree with this, this is Linux. We should not make assumptions,

Naatan avatar Jun 17 '17 15:06 Naatan

@Naatan Can you please give me an example where xdg-open doesn't work? xdg-open just uses xdg-query to get the default application for the mime type inode/directory. Which is work on every Linux system out there? Edit:

  • i might use gnome with Nemo instead of Nautilus or whatever stuff i want...

bilelmoussaoui avatar Jun 17 '17 15:06 bilelmoussaoui

i might use gnome with Nemo instead of Nautilus or whatever stuff i want...

xdg-open would be called first so as long as you have it on your $PATH, Komodo would call it and if it does not exist, call something else. (e.g. Nautilus).

@Naatan those 2 file managers does not cover most popular DE's. I think it's better to add a list of some popular file managers and search for them on the PATH rather than doing if-else for DE's. What do you think? :)

UPD: oops, that was in the initial fix. I'll add more managers and revert my latest change tomorrow so we'd have some fallbacks.

Defman21 avatar Jun 17 '17 16:06 Defman21

Can you please give me an example where xdg-open doesn't work? xdg-open just uses xdg-query to get the default application for the mime type inode/directory. Which is work on every Linux system out there?

It's not about it not working, it's about it being available. There is no reason to not have a fallback, it costs us nothing.

Naatan avatar Jun 17 '17 18:06 Naatan