MediaElch icon indicating copy to clipboard operation
MediaElch copied to clipboard

Images not saved

Open nkatsidis opened this issue 6 years ago • 13 comments

Mediaelch latest windows

I have many movies with previous accepted by kodi images with filenames:

  • disc.png
  • clearart.png
  • etc

I have defined in medialech in scraper <baseFileName>-clearart.png

but if Medialech finds clearart.png that is saved locally, by pressing save it does not create <baseFileName>-clearart.png

with movies that are scraped for the first time this does not happen. it only happens with previously saved movies where images already exist.

nkatsidis avatar Aug 25 '18 14:08 nkatsidis

Thanks for reporting this. I'm a bit late to answer but I'll try my best:

If I've understood you correctly, you have different files in a movie folder (movie, poster, clearart, etc). If you click "Save", MediaElch should rename the poster, etc?

MediaElch does not rename existing files unless told to. We have a feature called "Renamer" which is inteded for exactly that use case. See: https://mediaelch.github.io/mediaelch-doc/renaming.html

Please let me know if this helps. :-)

bugwelle avatar Sep 03 '18 19:09 bugwelle

No i dont want the existing files to be renamed. its just that mediaelch does not create lets say Movie-clearart.png if clearart.png exists same for disc etc

although i have set for I have defined in in scraper <baseFileName>-clearart.png to be created

nkatsidis avatar Sep 03 '18 20:09 nkatsidis

can you please check?

nkatsidis avatar Sep 14 '18 13:09 nkatsidis

can you please check?

Sorry, forgot about this issue :)

its just that mediaelch does not create lets say Movie-clearart.png if clearart.png exists same for disc etc

ok. I'm unsure on how we should handle this. I'll come back to you because I found another bug that is related to your issue:

Given following structure:

12 years a slave
 |- logo.png
 |- movie.mov
  1. Scrape 12 years a slave (The Movie Db)
  2. Save movie
  3. No movie-logo.png was created (this is actually expected, at least to my understanding)
  4. Click on the Logo and select another one
  5. Bug: Instead of the selected logo, the placeholder is shown. logo.png is not updated as well.

Thank you for reporting this. :)

bugwelle avatar Sep 15 '18 17:09 bugwelle

Any news on this?

nkatsidis avatar Oct 05 '18 21:10 nkatsidis

Sorry, no. I don't have much time at the moment for MediaElch. Furthermore I can't seem to reproduce the bug even though I wrote down the steps to reproduce it. :-/

bugwelle avatar Oct 06 '18 09:10 bugwelle

I see that you are back :) can i provide any more info about this issue?

nkatsidis avatar Nov 20 '18 22:11 nkatsidis

I'm sorry that it took me so long to answer. Most of my current contributions are bugfixes or changes related to publishing the next release.

I don't think that this issue will be fixed in the next version. I plan on refactoring a lot of code which will hopefully make it easier to identify the cause of this.

bugwelle avatar Dec 12 '18 12:12 bugwelle

thank you

nkatsidis avatar Dec 12 '18 13:12 nkatsidis

Hello, 2 adds on this bug : 1- All movies in the same folder have the same files logo.png, disc.png, clearart.png, there is no naming of those files depending on the movie name. image

2- in the parameters, if you specify that you don't want logo, disc art or clear art ... it does nothing, these files continue be created. image

I use MediaElch 2.6.0 stable for windows I hope I'm clear, I'm french and not that fluent in english anymore.

dirtkael avatar Aug 15 '19 19:08 dirtkael

OK, After more tests, you can forget about the first point.

I didn't change the settings about logo, clear art and disc art. Those are not set initially like the others. They miss "<baseFileName>-" in it. That's for the first point. About the second one ... It still doesn't work like it should.

Thanks for reading :)

dirtkael avatar Aug 16 '19 12:08 dirtkael

Hi there,

sorry for the late answer. I haven't looked into this issue again but will most likely do that next week. I haven't forgotten about this issue :)

bugwelle avatar Aug 27 '19 15:08 bugwelle

HI everyone,

I was not able to reproduce this issue and think that everything works as intended. But I may misunderstand the issues you are experiencing (maybe a language barrier?).

To summarize:
I have a movie with the following files:

Sintel (2010)
├── clearart.png
├── disc.png
├── logo.png
├── movie.mov
└── poster.jpg

My settings look like this:

Screenshot_20200408_162309

Steps I took:

  1. Reload all movies
  2. Click on Movie (which is marked "new") -> No poster, disc or clear art is visible. Nothing is shown. MediaElch ignores the existing files because they do not match the patterns (see screenshot).
  3. Scrape Movie with all details from TMDb
  4. Click "Save All"

The folder now contains the following files:

Sintel (2010)
├── clearart.png
├── disc.png
├── logo.png
├── movie-banner.jpg
├── movie-clearart.png
├── movie-disc.png
├── movie-landscape.jpg
├── movie.mov
├── movie.nfo
├── movie-poster.jpg
└── poster.jpg

=> All files without the movie- prefix were not changed.

The files are not used at all which contradicts the original issue if I understood you right.


@dirtkael I was not able to reproduce your second point. If I do not select any scraper for logos, discart, etc. in the custom movie scraper, none are downloaded or saved to disk. :-/

bugwelle avatar Apr 08 '20 14:04 bugwelle

The last point here was:

I was not able to reproduce this issue and think that everything works as intended. But I may misunderstand the issues you are experiencing (maybe a language barrier?).

I'm therefore closing this issue. Feel free to reply and I will reopen this issue.

bugwelle avatar Jun 27 '23 15:06 bugwelle