MediaElch icon indicating copy to clipboard operation
MediaElch copied to clipboard

multiple Files with Resolution-suffix treated as multi-part file

Open mihawk90 opened this issue 1 year ago • 1 comments

Describe the bug I was experimenting with my files earlier because my library is imported into Jellyfin and it supports Multiple Versions of a Movie. I was using "720p" and "1080p" as a differentiator/label (even used MediaElch to apply them via the <resolution> variable). However, after further experimentation I ran across a bug where MediaElch now seems to think both files are a multiple files of the same movie and consequently wants to rename them to part1 and part2 respectively. When reading out the Streamdetails, both runtimes of the files are also added up, making the movie twice as long.

To Reproduce Steps to reproduce the behavior:

  1. Have 2 mediafiles with similar names, ending in 720p and 1080p suffix
  2. Reload the library and check the loaded files
  3. Try renaming the movie

Expected behavior I would expect either a choice of which file to rename, or to rename both appropriately (if possible given the supplied naming template), or one of the files being ignored.

Screenshots image

image

mediainfo:

$ mediainfo "Babylon A.D. (2008) [tmdb-9381] - 1080p.mkv" 
General
Unique ID                                : 139606080195447372916276562351449038131 (0x6907272CC1E54372D72D843995ADDD33)
Complete name                            : Babylon A.D. (2008) [tmdb-9381] - 1080p.mkv
Format                                   : Matroska
Format version                           : Version 2
File size                                : 18.0 GiB
Duration                                 : 1 h 40 min
Overall bit rate mode                    : Variable
Overall bit rate                         : 25.5 Mb/s
Frame rate                               : 23.976 FPS
Movie name                               : Babylon A.D.
Encoded date                             : 2023-11-02 07:07:02 UTC
Writing application                      : MakeMKV v1.17.5 linux(x64-release)
Writing library                          : libmakemkv v1.17.5 (1.3.10/1.5.2) x86_64-redhat-linux

The 720p file is a symlink to this one (for testing purposes as mentioned).

MediaElch Version:

  • [ ] 2.10.5-dev (nightly)
  • [x] 2.10.4 stable

Operating System:

  • [ ] Windows
  • [ ] macOS
  • [X] Linux (distribution: Fedora 38)

Additional context Just for testing I also experimented using "Director's Cut" and "Extended Cut", and in that case it picked up only one of the files and ignored the other entirely. Which, I suppose is better then combining the two.

mihawk90 avatar Nov 02 '23 10:11 mihawk90

Thanks for opening this bug/feature request.

In the "separate directories" mode, MediaElch expects there to be a single movie. If there are multiple files, we interpret them as the same.

I'd say we shouldn't assume that multiple files are different parts of the same movie without a -part suffix.

bugwelle avatar Nov 04 '23 14:11 bugwelle