MediaElch icon indicating copy to clipboard operation
MediaElch copied to clipboard

2nd scraper search (or IMDB search) doesn't find anything if the year is included in the search

Open Metal-Snake opened this issue 1 year ago • 1 comments

Describe the bug When searching the Movie for the scraper, the first search works but the search for the second scraper doesn't find anything until the year is removed. (I'm not sure if this new behavior of having two searches is an intended feature or a bug)

To Reproduce Steps to reproduce the behavior:

  1. Go to Movies
  2. Click on "Load information" or cmd+f
  3. Click on the search result
  4. Window reappears with the second scraper written in Bold (very subtle hint if one doesn't know what's happening here)
  5. No search results
  6. remove the year from the search, now the movie will appear in the search result

Expected behavior Should only need one search, but in case this is an intended feature, it should at least find the movie with the year included in the search

Screenshots Bildschirmfoto 2023-07-08 um 12 40 24 Bildschirmfoto 2023-07-08 um 12 40 42 Bildschirmfoto 2023-07-08 um 12 40 55

MediaElch Version:

  • [x] 2.10.2 stable

Operating System:

  • [x] macOS

Additional context In 2.10.0 only one search was needed, and it gave search results just like the first search in 2.10.2 does.

Metal-Snake avatar Jul 08 '23 10:07 Metal-Snake

Hi,

thanks for reporting. This is kind of between "intended" and "missing feature".

With v2.10.0, movie scrapers were rewritten to allow parallel downloads and other features such as a preview window in the future. Also, the universal movie scraper is now no longer hard-coded to IMDb + TMDB, but works with all scrapers available. That had the side effect that the IMDb ID from the TMDB search result is no longer used.

Regarding the year in the IMDb search: It's always difficult to tell whether something is a year or part of the title. I will have to figure something out. I think I will do something like this:

  • remove the year from the original search query if it is IMDb
  • if the search query was modified, do not remove the year, even when scraping for IMDb (e.g. for movies that have a year in their title)

bugwelle avatar Jul 08 '23 17:07 bugwelle