MediaElch icon indicating copy to clipboard operation
MediaElch copied to clipboard

Scraping tv shows can produce thumb tags with incorrect url when no images can be found

Open nathanpw opened this issue 3 years ago • 0 comments

Thanks for the great software!

Describe the bug When I scrape a tv show that doesn't have thumbnails, using the tvdb scrapper. The episode .nfo contains a thumb tag with a "bad" url. i.e.: <thumb>https://www.thetvdb.com/banners/</thumb>

To Reproduce Steps to reproduce the behaviour:

  1. Open MediaElch
  2. Go to a tv episode that doesn't have a thumbnail image on the tvdb
  3. Click on the episode and scrape
  4. Use the tvdb scraper
  5. Check the info xml for a thumb tag

I was scrapping early Nova episodes (s05E04) from.: https://www.thetvdb.com/series/nova/seasons/official/2

One of the symptoms of this is when these episodes are added to Kodi it doesn't show a thumbnail, and it doesn't appear to be "immediately" added (if at all). If I re-scrap in Kodi it will get an image from the media.

I also noticed it appears the same behavior for tags for actors. But I am not sure if this actually causes any issues and I wasn't able to fully reproduce the problem with actors. I am not sure where the episode actor tags are coming from (kodi media export maybe). As I couldn't get the actors added to the nfo from mediaelch on a few episodes I tried.

Expected behavior I would think there should be no tag or empty thumb tags if no image can be found.

Screenshots n/a

MediaElch Version:

  • [ ] 2.8.13-dev (nightly)
  • [X] 2.8.12 stable

Operating System:

  • [ ] Windows
  • [ ] macOS
  • [X] Linux (distribution: Ubuntu 20.04)

Additional context Add any other context about the problem here.

nathanpw avatar May 16 '21 18:05 nathanpw