MediaElch icon indicating copy to clipboard operation
MediaElch copied to clipboard

Extra Fanart should no longer be stored in extrafanart folder

Open snake3ca opened this issue 3 years ago • 3 comments

Describe the bug Mediaelch should no longer store extrafanarts in the extrafanart folder as kodi appears to be using a different naming convention for extrafanart now.

Kodi is storing addtional fanarts like this now.

... /TV Show 1/poster.jpg ... /TV Show 1/fanart.jpg ... /TV Show 1/fanart1.jpg ... /TV Show 1/fanart2.jpg ... /TV Show 1/fanart3.jpg ... /TV Show 1/clearlogo.png ... /TV Show 1/season-specials-poster.png ... /TV Show 1/season-specials-landscape.png ... /TV Show 1/season01-poster.png ... /TV Show 1/season01-landscape.png

... /Movie Name (2017)/Movie File Name-poster.jpg ... /Movie Name (2017)/Movie File Name-fanart.jpg ... /Movie Name (2017)/Movie File Name-fanart1.jpg ... /Movie Name (2017)/Movie File Name-fanart2.jpg ... /Movie Name (2017)/Movie File Name-fanart3.jpg ... /Movie Name (2017)/Movie File Name-clearlogo.png

or

... /Movie Name (2017)/poster.jpg ... /Movie Name (2017)/fanart.jpg ... /Movie Name (2017)/fanart1.jpg ... /Movie Name (2017)/fanart2.jpg ... /Movie Name (2017)/fanart3.jpg ... /Movie Name (2017)/clearlogo.png

Expected behavior To follow naming convention that kodi uses to scan for extrafanart.

MediaElch Version:

  • [ ] 2.8.10 stable

Operating System:

  • [ ] Linux (distribution: Debian 10)

snake3ca avatar May 07 '21 15:05 snake3ca

In a perfect world, the "old way" could still be available as a preference -- currently intentionally staying on an old skin on Leia which uses the old scheme. I understand this is a narrow corner case, just weighing in.

emersonrp avatar Nov 13 '21 21:11 emersonrp

Related issue: #1243

I would also love to be backwards compatible to older Kodi versions. I'll see what works best. :)

bugwelle avatar Nov 27 '21 09:11 bugwelle

I actually just read about this in the Kodi wiki (I haven't used Kodi in a while I guess lol), and yes it would be nice if we could get this. According to the Wiki, the extrafanarts folder applies to "v17 and prior". That was in 2017, we're currently at 20 with 21 on the Horizon.

I would also love to be backwards compatible to older Kodi versions. I'll see what works best. :)

While I do agree that backwards compatibility would be nice, the question is for how long that is actually reasonable to support. Either way if you do want to keep backward compatibility, I'm not sure how feasible this is but... why not create hardlinks to the files? So they would be in both the movie's root-directory as well as the extrafanarts while only taking disk space for one file being present. That said, I'm not sure how Kodi or Jellyfin react to both being present at the same time.

mihawk90 avatar Nov 05 '23 16:11 mihawk90